Identityserver4: Breaking Changes from 2.2.0 to 2.3.0?

[fabich]

hi

After updating to 2.3.0 from 2.2.0 our application breaks:

System.Data.SqlClient.SqlException:
Invalid column name 'Created'.
Invalid column name 'DeviceCodeLifetime'.
Invalid column name 'LastAccessed'.
Invalid column name 'NonEditable'.
Invalid column name 'Updated'.
Invalid column name 'UserCodeType'.
Invalid column name 'UserSsoLifetime'.

do you have any information on this?

thank you for your help

[milosloub]

Same problem here

[scottbrady91]

More properties were added to the EF models. Some of these make their way up to IdentityServer, some don't.

You'll need to create a new migration.

[milosloub]

Ah, sure, just new migrations. Now it's working again, thanks!

[StevenLiekens]

This just bit me too. Please don't publish minor versions that require manual intervention when updating. @scottbrady91

[fabich]

@StevenLiekens my point exactly

[leastprivilege]

That's how EF works. We won't do a new major release just because we are adding a field or table.

[leastprivilege]

But what we will do in the future is to add a remark to the release notes if EF requires a new migration.

[StevenLiekens]

Then also make it clear you don't follow semver all the way. Sorry for being brutal but you're breaking people's expectations by following your own versioning scheme.

[leastprivilege]

The we need to agree to disagree.

[ravero]

It took me a long time to realize the new version issue.
How do you create a migration for a third party library?

[brockallen]

How do you create a migration for a third party library?

http://docs.identityserver.io/en/latest/reference/ef.html#database-creation-and-schema-changes-across-different-versions-of-identityserver

[fabich]

http://docs.identityserver.io/en/latest/reference/ef.html#database-creation-and-schema-changes-across-different-versions-of-identityserver

We also publish sample SQL scripts for the current version of the database schema.

IdentityServer4.EntityFramework.Storage is archived and hasn't been updated for over five months

Could you please update documentation:
https://github.com/IdentityServer/IdentityServer4/tree/master/src/EntityFramework.Storage/migrations/SqlServer/Migrations

[brockallen]

@fabich the docs have an easy to use "Edit on Github" button to submit PRs

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.