Id: Adjust preset list based on connected or nearby features

[bhousel]

Currently the preset list is ordered by most recently used followed by the default common presets. We can improve the ranking of some presets based on connected or nearby features.

Examples:

Connected features

• When adding a highway-highway vertex, show Traffic Signals at the top
• When adding a motorway-motorway_link vertex, show Motorway Junction at the top
• When adding a highway-footway vertex, show Pedestrian Crossing at the top
• When adding a preset to the endpoint of a residential highway, show Turning Circle at the top

Nearby features (also see everything in #4138)

• When looking at a bank, show ATMs at the top
• When looking at a park, show Picnic Tables at the top
• When looking at a gas station, show Convenience Store, Compressed Air, Vacuum at the top
• When looking at a post office, show Post Box at the top

etc..

cc @1ec5

[1ec5]

There’s a neverending list of presets we could helpfully suggest, so it’ll be a an area for continuous improvement – and a boon for micromapping. 😄

More connected features:

• When a vertex of Residential Street is selected, show Pedestrian Crosswalk, Traffic Calming
• When a vertex of Building is selected, show Entrance
• When adding a line connected to Motorway or Trunk Road, show Motorway Link or Trunk Link, respectively

More nearby features:

• When adding an area inside School Grounds, show School Building, Playground, Sport Pitch
• When adding a line or area inside Golf Course, show the Golf group
• When adding a line near Residential Road, show Sidewalk
• When adding a line inside Building, show Corridor
• When adding a line inside Park, show Footpath
• When adding a point inside Park, show Fountain, Playground, Picnic Site, Grill
• When adding a point near Secondary Road etc., show Bus Stop
• When adding an area near Church, show Graveyard, School Building
• When adding an area inside Residential Area, show House, Apartments, Garage

[bhousel]

Good suggestions, @1ec5.

Also I want to add, we have traditionally avoided building this kind of OSM tagging logic into iD itself, (as you said, it's a "neverending list of presets"). So the rules for this issue and #4138 should exist in the preset definitions, not in JavaScript code. Something like:

{
    "icon": "park",
    "geometry": [
        "point",
        "area"
    ],
    "related": {
        "contains": [
            "leisure/picnic_table",
            "amenity/bench",
            "amenity/bbq",
            "amenity/fountain",
            ...
        ],
        "nearby": [
            "highway/footpath",
            ...
        ]
    },
    "terms": [ ... ],
    "tags": {
        "leisure": "park"
    },
    "name": "Park"
}

{
    "icon": "poi-traffic-signals",
    "geometry": [
        "vertex"
    ],
    "fields": [
        "traffic_signals"
    ],
    "related": {
        "connects": [
            "highway/trunk",
            "highway/primary",
            "highway/secondary",
            ...
        ]
    },
    "tags": {
        "highway": "traffic_signals"
    },
    "terms": [ ... ],
    "name": "Traffic Signals"
}

[1ec5]

More nearby features

Note that whether something is “nearby” can depend on the latitude, as seen in #5101 and #1520.