Hyrax: Embargo Date defaults to tomorrow

[carolyncole]

Descriptive summary

In Hyrax Master the default embargo date is tomorrow. I am guessing this would never be valid default behavior for any institution. A way to configure the default date would likely be the best, but the current behavior is likely to cause issues.

https://github.com/samvera/hyrax/blob/master/app/views/hyrax/base/_form_permission_embargo.html.erb#L4

Rationale

Users may not notice that the default date is tomorrow and expect a more realistic default.

Expected behavior

This is likely to be institution dependent.

Actual behavior

Defaults to embargo until tomorrow

Steps to reproduce the behavior

1. Login to the system
2. Create a new work
3. Click on embargo
4. Notice the default date is tomorrow

[hannahfrost]

@mjgiarlo I think this ticket is a good example of something that the repo-managers team could be enlisted to weigh in on.

I support the idea to offer the admin the ability to configure the repository's default (maximum?) embargo date. Hyku's admin set configuration settings offers this at the admin set level. If the repo has admin sets disabled, then you need a place to easily set the date.

[mjgiarlo]

Tagging @samvera/hyrax-repo-managers for their feedback.

[julesies]

@hannahfrost I think being able to set a default and max would be nice. Would it be for all work types or could you specify different maxes for each work type? This might not be possible, but FWIW here is our use case...we currently support 4 different embargo policies for self-deposit and offer these settings: no embargo selection allowed, 1 year max, 2 year max, or unlimited (date picker). I know this sounds a bit complicated and I'm not really arguing for Hyrax to do this, but this is the situation we've supported for many years.

[vantuyls]

Our use case has involved building in a picker for embargo lengths with the options of 6months, 1 year, 2 years, or date picker - with the default set to 6 months. We also plan to implement a pick list of general reasons for the embargo (e.g. impending publication, intellectual property, etc.).

To @julesies comment - it would be useful (and seems possible) to allow different embargo picking behavior by work type.