Hyrax: Don't attempt to display ungenerated derivatives

Created on 19 Jun 2017  路  6Comments  路  Source: samvera/hyrax

A works show page having a video file_set rendered is failing with 404 when the source of the video tag is sent to the server.

https://github.com/samvera/hyrax/blob/master/app/views/hyrax/file_sets/media_display/_video.html.erb

When removing the file: 'mp4' and file: 'webm' parameter in each of the path generators, the video is rendered and is capable of playing.

If I'm reading this correctly, the DownloadsController seems to expect the file_set name in the file param: https://github.com/samvera/hyrax/blob/master/app/controllers/hyrax/downloads_controller.rb#L63

bug

Most helpful comment

@revgum so the UI is trying to server the derivatives enabled by that flag. The fix is probably to wrap the UI partial with a test for that configuration value.

All 6 comments

@revgum do you have ffmpeg enabled in the hyrax configuration?

https://github.com/samvera/hyrax/blob/master/lib/generators/hyrax/templates/config/hyrax.rb#L53

@jcoyne no we don't

@revgum so the UI is trying to server the derivatives enabled by that flag. The fix is probably to wrap the UI partial with a test for that configuration value.

Wrapping the UI with a flag test seems slightly fragile in production, since the flag could change values and still not have derivatives generated.

Perhaps there's a solution that involves displaying the derivative video when it is present, and gracefully failing otherwise?

@no-reply Can we make the guarantee that the derivative video is on the same system? In our system (not hyrax) we have wowza make video derivatives. While this isn't the default configuration, it does seem like it wouldn't be uncommon. Hyrax's video handling is extremely basic an I suspect it doesn't support a large number of use cases.

Closing this issue as it does not seem to be a problem any longer for the original reporting institution and no one else has reported experiencing this issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jcoyne picture jcoyne  路  3Comments

carolyncole picture carolyncole  路  5Comments

chrisdaaz picture chrisdaaz  路  7Comments

jcoyne picture jcoyne  路  5Comments

mjgiarlo picture mjgiarlo  路  3Comments