Hyperapp: More than one action breaks actions!

Created on 27 Dec 2017  路  10Comments  路  Source: jorgebucaran/hyperapp

Sorry guys, I know we're chomping at the bit 1.0, but I found this really wierd & serious bug...

See this codepen: https://codepen.io/zaceno/pen/JMWjwQ

Try typing in the input field. Notice that it works. Now: uncomment L12 ( otherAction: _ => ({otherVal: true}))

馃挜

...the input field breaks. From my debugging, it looks like the set action isn't called even.

(... if this is a user error, I'm going to be very embarrassed...)

Bug

Most helpful comment

Fixed in 0.18.3! 馃帀

All 10 comments

if i'm change the order of the actions it works again... wired

Definitely looks like a bug with 0.18.1.

If you change the script reference to https://unpkg.com/[email protected] it works.

Looks like the otherAction is getting called on accident somehow.
I added a state tree to this example. We can see it add otherValue: https://codepen.io/dustindowell/pen/aEJObB

馃

I noticed that the counter example now only calls the up action. Adding a NOP action breaks the example entirely 馃槷

Switching back to 0.18.0 fixes both of these issues for me... 馃

@zaceno @okwolf @whaaaley @selfup Can you reproduce this locally or could it be only a CodePen issue?

My local examples work as usual. 馃

I think this could be a bug in uglify-js, we're going to need to downgrade it. 馃帗

@JorgeBucaran confirmed that it works with the non-uglified bundle for 0.18.1. How bizarre...

Fixed in 0.18.3! 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jacobtipp picture jacobtipp  路  3Comments

dmitrykurmanov picture dmitrykurmanov  路  4Comments

zaceno picture zaceno  路  3Comments

dmitrykurmanov picture dmitrykurmanov  路  3Comments

zhaotoday picture zhaotoday  路  3Comments