Hydrogen: MIDI Note selector shows note number instead of note name

[elpescado]

Noticed in 1.0.0 branch:

Before:

After:

[mauser]

Hi!

That's my fault, or better said: it was my intention :)

I've changed the display to make it easier to see which midi note will be played/exported, since the name/octave seems to be not exactly defined. But maybe it should be made configurable...

[trebmuh]

+1 it would be great to have it as a Preference maybe? Or even better/easier: changing from one to the other if you click on it?

[elpescado]

Maybe we could enlarge selector to accomodate 6 chars, eg "36(C3)". Though I like the idea of switching mode by clicking on it.

[thijz]

i like the idea of @elpescado : just keep it simple and use both note and midi nr in the selctor
i would however prefer "C3 (63)" since it puts the 'musical' notation first, but either way is fine for me :-)

maybe it would be good to change the 'NOTE' label to 'NOTE (midi note)' so it is immediately clear what the double notation means

alternatively an option could be added in the preferences menu to allow the user to display the notation of his choice

[elpescado]

After thinking about it, showing note number makes sense. After all, drum kit is an unpitched instrument - drum kit elements don't have pitch, so music note names are meaningless in this context.

On the other hand, virtually all other music applications use note names for drums, so showing note names improves interoperability.

[trebmuh]

I do agree that "MIDI NOTE : 63 (C3)" would be useful.

[thijz]

related to
https://github.com/hydrogen-music/hydrogen/issues/63
https://github.com/hydrogen-music/hydrogen/wiki/MIDI-implementation

[trebmuh]

Note: the actual link is https://github.com/hydrogen-music/hydrogen/wiki/MIDI-implementation---current-state-and-usecases