Hugothemes: New Theme : Twenty Twenty Hugo

Created on 27 Apr 2020  路  15Comments  路  Source: gohugoio/hugoThemes

Theme submission

Please make sure that you have read the theme submission guidelines before submitting a theme. The guidelines provide all relevant information and requirements that have to be fulfilled before the submission. Please tick the relevant boxes for your theme in the checklist below:

Link to my theme repository: https://github.com/themefisher/wordpress-twenty-twenty-hugo

I made sure that...

  • [x] the repository contains a good README.md describing my theme
  • [x] an open source license has been added to LICENSE.md
  • [x] all metadata have been added to theme.toml
  • [x] screenshots have been added in the images/ folder with the required dimensions
  • [x] in case I'm using a customized demo via the exampleSite folder that
  • [x] I tested my theme against the gohugoio/HugoBasicExample

    • [x] I've checked the developer tools' console in my browser for error messages

  • [x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

N.B. By submitting a theme to the Hugo Themes Showcase you understand that you need to maintain your theme. You will need to keep an eye on whether your theme's demo generates on the Hugo website, whenever there is a new release. We are a very small team and we just cannot keep up opening issues in the various theme repositories to notify authors. Whenever a theme demo breaks and remains broken then at some point it will be removed from the list without prior warning. If you no longer wish to maintain a theme please let us know.

New themes will usually be promoted on Hugo's official Twitter account. If you would like to be mentioned in the tweet please add your Twitter username to this submission.

Link to my Twitter account (optional): REPLACE-WITH-URL

Feel free to ask questions. We're glad to help.

All 15 comments

Hello @Somrat37

First of all I want to point out that the original Twenty Twenty Wordpress theme has a GPL v2 LICENCE that is a copyleft license. Copyleft means that a derivative work also has to be licensed under the GPL license terms.

In the linked theme repo of the derivative Twenty Twenty Hugo Theme you are using an MIT LICENSE and that violates the GPL LICENSE of the original.

Furthermore I am not in favor of hosting a port of the default Twenty Twenty Wordpress theme in the Hugo showcase. I think that it will be confusing new users to showcase a theme that bears the WordPress brand in its title.

However that is my opinion and the other maintainers need to voice their own opinion on the matter whether this theme can be accepted in this repo.

cc: @bep @digitalcraftsman

Hello @onedrawingperday ,
Thanks for your reply . We are going to change the theme license . We saw few author convert wordpress base themes for hugo . https://themes.gohugo.io/tags/wordpress/ and thats why we made this theme . Some Wordpress users might be interested to use same wordpress theme in hugo that why we made this theme . Lets see what @bep and @digitalcraftsman put their opinion
Thanks

@mehedi-sharif

@bep has already posted his opinion. (see thumbs up in my post above)
@digitalcraftsman is M.I.A. (missing in action)

But still we are 2 maintainers who agree on this matter. So no need to tag the others further in your posts.

Here is what you need to do.

The theme should not have the WordPress brand name in the theme name.

You need to call it something else like Hugo Twenty Twenty or Twenty Twenty (I prefer the latter), update theme.toml, the README, screenshots and all content files accordingly.

Also make sure to mention at the beginning of the README, that this is a port of the default theme for WordPress theme for the year 2020.

Regarding the other ports of WordPress themes in the showcase, none of them features the brand name WordPress on their title. Hugo may be an Open Source product but it has its own distinct brand name. We will not be hosting themes that feature other brand names in their title or in their demo. There is precedent for this. In the past we have blocked the demo of another theme, whose content read like an advert for another software tool.

Also please note @mehedi-sharif that in the future, I expect you to research basic things like LICENSES and how to honor their requirements when porting existing themes. Next time that I see a theme submission violating a LICENSE, I will be closing it without further discussion.

Hello @onedrawingperday
Thanks for your reply . When we do something we check the hugo theme repository as reference . In this list none of them change their theme name and added hugo in their theme name (https://themes.gohugo.io/tags/wordpress/ ) . Even there is twenty fourteen theme also not hugo twenty foruteen theme . But still it seems a conflict and we will obviously think about and change things according to your suggestion.

Also please note @mehedi-sharif that in the future, I expect you to research basic things like LICENSES and how to honor their requirements when porting existing themes. Next time that I see a theme submission violating a LICENSE, I will be closing it without further discussion.

In some cases it seems you don't like me at all . Our plan was to release this theme in GPL (we have to as the core product is in GPL license ) , but my developer made a mistake and he put it as MIT . . I will take your "Notice" seriously and hope this will not repeat again (the basic license knowledge) . Thanks for your time

In some cases it seems you don't like me at all .

@mehedi-sharif

There is no like or dislike. My time is limited and cannot be wasted on fundamental things like licenses.

The README of this repo has been expanded substantially to save us time from the submission process. I can always add a paragraph about the requirement to respect licenses that will be identical to what I posted above.

This was not a personal comment and you should not take it like that.

Now as I said above I prefer Twenty Twenty as a name -no need to add Hugo but you have to remove WordPress from the name-

Once the above requirements are met let me know so that I can review the theme further.

I have just added a section in the repo README about a submitted theme's (original or derivative) LICENSE requirements.

Hallo everyone,

sorry for joining so late.

Furthermore I am not in favor of hosting a port of the default Twenty Twenty Wordpress theme in the Hugo showcase. I think that it will be confusing new users to showcase a theme that bears the WordPress brand in its title.

We had a very similar discussion last year with another theme (it took me some time to find). I'm sharing Bj酶rn Erik's standpoint:

Bj酶rn Erik: It would be even better if you could make the exampleSite not to be an ad for Gatsby. Gatsby is great, but isn't something that feels natural to promote on the Hugo theme site


Regarding the GPL license: when running hugo new theme ... a MIT license is generated by default. A lot of theme authors don't replace the palceholder with their own name, indicating they missed this file.

@mehedi-sharif just replace the license as you already intended to do so. Don't take it as a personal offense. Mistakes happen.

Hey all,

I am sorry for making this mistake, I fixed those issues. the new repository URL is :
https://github.com/themefisher/twenty-twenty-hugo

@Somrat37

Thank you for the changes. I acknowledge that this was a mistake and accept it, since as was said above mistakes happen.

However please note that a mistake in a theme's license can cause several problems down the line and that is why I added the section about licenses in the README.

I'm sorry if I came across as harsh but licenses are not something to be casual about and I hope that you and @mehedi-sharif can understand my point of view.


Now regarding the name, I thought that above @mehedi-sharif wanted to use the name Twenty Twenty (without the word Hugo). Yet in the revised theme.toml I see the name Twenty Twenty Hugo.

Can you please confirm whether Twenty Twenty Hugo is indeed the name that you want to use for this theme?

Thanks.

Hello Alexandros ,
Thanks for your contribution in hugo community , and I and my team really appreciate your effort . Now for the theme I think we should go with the name twenty twenty hugo (as it might reduce the confusion with wordpress users )
Thanks

@Somrat37

While testing the demo I noticed the following section further down the homepage:

Screenshot_2020-04-29_13-44-34

As stated in the theme submission guideline you need to:

to provide generic content that is as neutral as possible in the theme's exampleSite.

We do not accept donation & subscription links in theme demos, so you need to remove the section shown in the screenshot above.

Also you need to provide the actual history of this theme in its description at line 4 of theme.toml i.e. Port of the Wordpress Twenty Twenty theme to Hugo. or similar.

Furthermore you need to update all screenshots so that they feature the new name of the theme and not the old one.

Thanks for your quick response, I have changed the content of this section ( now it doesn't provide generic content that is as neutral as possible in the theme's exampleSite ).
I have also added the description on theme.toml file and fixed the screenshot images.

@Somrat37

I have added the theme to the repo in 566f40f


@digitalcraftsman

This theme is a port of the default theme for Wordpress installations in 2020.

@Somrat37 @mehedi-sharif, your theme is already live on Hugo's theme site has been promoted on Hugo's official Twitter account.

Thank you so much Lars ,
Hopefully we are going to release more and more themes .

Was this page helpful?
0 / 5 - 0 ratings

Related issues

onedrawingperday picture onedrawingperday  路  5Comments

peaceiris picture peaceiris  路  4Comments

kdevo picture kdevo  路  4Comments

kskarthik picture kskarthik  路  7Comments

gundamew picture gundamew  路  4Comments