Hugothemes: Demos with empty homepage and/or wrong posts list

Created on 16 Aug 2019  Â·  148Comments  Â·  Source: gohugoio/hugoThemes

Due to the nature of the changes that were introduced in Hugo v.0.57.0 (briefly described in https://github.com/gohugoio/hugoThemes/issues/678#issue-480803827) a great number of theme demos now display empty homepages and/or post lists that point to section lists (instead of individual posts).

The solution to the problem would be the use of mainSections for theme lists on the homepage (as we have been advocating for a while now) as well the following (or its variations) in list templates:

{{ $pages := .Pages }}
{{ if .IsHome }}
{{ $pages = .Site.RegularPages }}
{{ end }}
{{ $paginator := .Paginate $pages }}

Hugo v.0.58.0 was released on the 4th of September 2019 and the breaking changes to the home.Pages collection that were reverted in 0.57.2 have been re-introduced Theme authors need to issue the fixes described above if they wish to keep their themes listed in the Hugo Showcase.


- Broken themes will be removed around the end of September -

Also note that #668 is in progress and the guidelines for maintaining a theme in the Hugo Showcase are about to change. Theme authors are encouraged to track this issue.

- If you no longer plan to maintain a theme please let us know -

Furthermore there is a related notice in the forum to alert theme authors about the breaking changes.

Below is the full list of affected themes (I have not included the few themes whose authors are working on a fix as mentioned in #678 ):
Midnight theme is affected by another issue and it will be kept in this repo until there is a resolution (even if its demo does not generate)
Hugo Future Imperfect Slim fixed in pacollins/hugo-future-imperfect-slim@afbf3ccb
Yignyang fixed in joway/hugo-theme-yinyang@5091a6c
Hugo Flex fixed in de-souza/hugo-flex@0d64b46
Hugo Lamp fixed in huyb1991/hugo-lamp@b4408fd

  1. Cocoa-EH fix in progress see: https://github.com/mtn/cocoa-eh-hugo-theme/issues/138 @mtn
  2. Dream @g1eny0ung
    Zen fixed in frjo/hugo-theme-zen@a942441
    Bingo fixed in gundamew/hugo-bingo@ea9283f
    OneDly Project fixed in cdeck3r/OneDly-Theme@3302b93
    Alpha Church fixed (see #687 )
    Minimage fixed in d-kusk/minimage@959ef80
    Tikva fixed in geschke/hugo-tikva@af5722f
  3. Simple Blox @okabrionz
  4. Hurock @TiTi
    Aether fixed in josephhutch/aether@0cf324b
    Binario fixed in Vimux/Binario@9f5ca76
    Newsprint theme removed in #685
    Indigo fixed in AngeloStavrow/indigo@a824342
    eiio fixed in leonhe/hugo_eiio@cc47f86
    Base 16 fixed in htdvisser/hugo-base16-theme@861b48a
    Black & Light fixed in davidhampgonsalves/hugo-black-and-light-theme@4168cd6
  5. Start Bootstrap Clean Blog @UtkarshVerma
    Niello fixed in https://github.com/guangmean/Niello/commit/cc55110be275cb7ab6d0b19583afbb9a3433ad2a
    Massively fixed in https://github.com/curtistimson/hugo-theme-massively/pull/72
    Hyde-Hyde fixed as per htr3n/hyde-hyde@ad9701b
    Techlog Simple fixed in mazgi/hugo-theme-techlog-simple@fdf9ccb
    Arabica fixed in nirocfz/arabica@ae66e72
    Ezhil fixed in vividvilla/ezhil@3154483 and vividvilla/ezhil@bb28e76
  6. Yinwang @chinanf-boy
    Inkblotty fixed in https://github.com/tosi29/inkblotty/commit/a2b99bdf71090428b52d5976288a83584ffb45a7
    Paper fixed in nanxiaobei/hugo-paper@68a57bb
    Cayman fixed in https://github.com/zwbetz-gh/cayman-hugo-theme/commit/c5c1915d3d2a69bda61860f3a7846f6601540292
  7. Athena fix in progress see: https://github.com/mtn/athena-hugo-theme/issues/4
    Manis fixed in yursan9/manis-hugo-theme@30ff78a
    Ghostwriter fixed in jbub/ghostwriter@6e9eabc
  8. Hugo Nuo @laozhu
    Even fixed in olOwOlo/hugo-theme-even@5a3e559
  9. Hyde Y @enten
    Air fixed in syui/hugo-theme-air@3bc80b5
    Simplicity fixed in #687
    Beautiful Hugo fixed in halogenica/beautifulhugo@1d75ccd
  10. Changelog Theme @jsnjack
    Dusky Neon Potato fix in VVelox/hugo-dusky-neon-potato@a9bd193
  11. Blackburn @yoshiharuyamashita
    Paper CSS fixed in zwbetz-gh/papercss-hugo-theme@698fe6a
    Hyde fixed see: spf13/hyde@3080504
  12. Zozo @zhoukai620
    Techdoc whitelisted in #691
    Adam & Eve fixed in blankoworld/hugo_theme_adam_eve@e925bcd
    Charaka fixed in natarajmb/charaka-hugo-theme@de01c10
    Hugo Apps Theme fixed in #687
  13. Mondrian @redraw
  14. Spectrum @silvanocerza
    XMin fixed in yihui/hugo-xmin@6123be2
  15. Pickles @mismith0227
  16. Castanet the author replied - (also see https://github.com/gohugoio/hugoThemes/pull/687/commits/863c6778b434733573cc1c1b243ca050bbc13845) @mattstratton
  17. Hamburg @hauke96
    Pacman fixed in coderzh/hugo-pacman-theme@ea7d497
  18. Shapez @djuelg
  19. Dream Plus
    Lanyon fixed in tummychow/lanyon-hugo@33ecb36
  20. Hugo NES Classic (notified author in https://github.com/rjayasinghe/hugo-nes-classic/issues/2 because it was impossible to tag him here)
    Pixyll fixed in azmelanar/hugo-theme-pixyll@c25f592
    [Minimal Bootstrap Hugo Theme fixed in zwbetz-gh/minimal-bootstrap-hugo-theme@634920a
    Kiss fixed in ribice/kiss@7ea3147
  21. Hugo Bootstrap Premium @appernetic
    Hugo Dusk fixed in gyorb/hugo-dusk@b0d2bc7
    Hugo W3 Simple fixed in jesselau76/hugo-w3-simple@601d63c
  22. Bleach @digivend
    Now UI fixed in cboettig/hugo-now-ui@82c3eb0
    Travelify fixed in balaramadurai/hugo-travelify-theme@65f7a10 - also whitelisted in #691
  23. dockDock @vjeantet
    hugo h5bp fixed in garvincasimir/hugo-h5bp-simple@f6b0f3a
    Herring Cove removed in e736afe
    Hugo Minimalist SPA fixed in #683
    Lithium fixed in jrutheiser/hugo-lithium-theme@fba4893
    Beg Unmaintained theme removed in #690
    81. Den fixed in shaform/hugo-theme-den@553b158 - (also see: #687 )
    Robotico whitelisted in #691
  24. Simple Hugo Theme @Xzya
    Silhouette fixed in mattbutton/silhouette-hugo@be305fb
    Octopress fixed in parsiya/Hugo-Octopress@3f80dea
  25. Hugo Bootstrap @Xzya
    Bootstrap BP fixed in spech66/bootstrap-bp-hugo-theme@68314b7
  26. Hugo multi Bootswatch @mpas
    Oldnew Mashup whitelisted in #691
    Er fixed in lingxz/er@ebdb186
    Hugo Grapes fixed in shankar/hugo-grapes@af4af64
    Hugo Classic fixed in goodroot/hugo-classic@bafd650
    Hugo Now fixed in mikeblum/hugo-now#5
    Dark Simplicity fix in kritoke/darksimplicity@e00dc41 and kritoke/darksimplicity@d516015
    Internet Weblog fixed in jnjosh/internet-weblog@2fa06ec
    Simple A fixed in AlexFinn/simple-a@b22f385
  27. Finite @lambdafu
    Rusty theme removed in #699
  28. Code Editor @aubm
    Hugo Cards the way this theme was refactored in bul-ikana/hugo-cards@e3248ef is not ideal, so I had to send #706 to cover this setup in the Build Script.
  29. Phugo @aerohub
    Cocoa unmaintained removed in #680
    Potato Dark fixed in https://github.com/surajmandalcell/potato-dark/pull/7/commits/241dea801d992328753eda8c6e40505c26fb43ea
  30. AllinOne @orianna-zzo
  31. Basics @arjunkrishnababu96
  32. One @resugary
    Slim fixed in https://github.com/zhe/hugo-theme-slim/commit/f666effe196af5f9a578f9b652229c96803a5b98
    BeyondNothing fixed in https://github.com/salcan/BeyondNothing/commit/2931c2abf0964f1053c4776c5288ed3f02a7fe79
  33. Martial Paper @pedrodude
  34. Would have been cool in the 80s @pedrodude
  35. Sublime Hugo @dt801ts
  36. Classless @fiatjaf
    Landing Page unmaintained removed in #692
  37. Bootie Docs @progrhyme
    Hugo Frais fixed in the2ne/hugo-frais@cd01972 and the2ne/hugo-frais@056db8f
  38. Tracks @ageekymonk
  39. Phlat @nraboy
    Wave fixed in syui/hugo-theme-wave@68e2aed
    Paperback fixed in dashdashzako/paperback@9b58eba
    onetwothree fixed in https://github.com/schollz/onetwothree/pull/12
  40. Casper @vjeantet
  41. Casper Two @eueung
  42. Simpledoc Theme
    Elephants fixed in meibenny/elephants@7c40d2c
    Reveal JS whitelisted in #691
  43. Luxury Theme
    Gentoo removed in https://github.com/gohugoio/hugoThemes/commit/7fdec13c4a1ebb93dacb3ac64bc5f92fceb3f586
  44. Retroful Hugo @5ARMALE
  45. Strata - the maintainer is aware
    Liquorice fixed in eliasson/liquorice@4f2af3b
    Hikari fixed in digitalcraftsman/hugo-hikari-theme@314516a
  46. Minimalist - incorrect list - the maintainer is aware
    Journal removed in #694
  47. GitHub Project Page @nsomar
  48. Red Lounge @tmaiaroto
  49. Steam - the maintainer is aware
  50. AMP @pdevty
    Light Hugo fixed in tblyler/light-hugo@5ef28a4
  51. Icarus - the maintainer is aware
  52. Hugo Geo @alexurquhart
  53. GoHugo AMP @wildhaber
  54. NeXT @leopku
    Hugo Scroll unmaintained and removed in #692
    Hugo Uno unmaintained and removed in #693
    Hugo Zen unmaintained and removed in #693
  55. Heather Hugo @hbpasti
    Remark Twemoji removed in #690
    Remark Minion removed in #690
    Nixon removed in d46f2d5 also see https://github.com/gohugoio/hugoThemes/issues/682#issuecomment-524798374
  56. Darkdoc @adejoux
    Twenty Fourteen fixed in jaden/twentyfourteen@89e9097
  57. Angel's Ladder @tanksuzuki
  58. Hugo Bootswatch @nilproductions
  59. Rocktopus @esell
    Gindoro removed in #690
  60. Projecthub
  61. Tachyons @marloncabrera
    Shiori removed in #690
  62. Universal Theme @devcows

Most helpful comment

Unrelated, but shout out to @onedrawingperday - you sir are awesome for managing this and assisting everyone. Thank you for what you do for hugoThemes!

All 148 comments

I believe I have fixed https://themes.gohugo.io/hugo-theme-zen/ now.

Thanks for the work keeping the Themes section updated and relevant!

@frjo Thanks the theme demo will be fixed when @digitalcraftsman updates the themes in the repo.

The themes have been updated.

The real impact of Hugo 0.57 breaking changes is even bigger than 155 themes, which stated above.

What about broken taxonomies list pages? As an example, Mainroad. This theme is not listed (because homepage works), but it's affected too. I am sure this is not a complete list of affected themes. I have three themes in themes.gohugo.io and all of them affected somehow: Binario, blank, Mainroad. And worst of all, it was done without notification or any warning.

I'll update my themes ASAP, but probably tomorrow, not today.

I'll update my themes ASAP, but probably tomorrow, not today.

There is a one month window so take your time.

Also please note that #668 is in progress and I suggest you track it because the guidelines for maintaining a theme in the Hugo Showcase are about to change..

We are a very small team and this is the last time that I spend an exorbitant amount of time running around notifying 155 people.

Thanks.

I've created a fix for the Massively theme and would appreciate a review if anyone has chance:

https://github.com/curtistimson/hugo-theme-massively/pull/72

Thanks

@onedrawingperday we could use Hugo's Twitter account to reach out to theme maintainers. Just let me know how to inform them in 280 characters.

@digitalcraftsman

If you could tweet the following:

Theme authors you may want to check out https://github.com/gohugoio/hugoThemes/issues/682 to see if your theme is currently broken in Hugo v.057.1

FWIW, and I know I'm probably in the minority here, I do not have a Twitter account. Please also consider using email, or a blog or something I can subscribe to. Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released? Having them just kind of spring up after a release if you're not heavily involved in Hugo development doesn't feel great.

@digitalcraftsman

Also note that currently I have hit a GitHub limit. It seems that only 50 user mentions are allowed per post. So I cannot notify more people in the first post of this topic and it will not be practical for me to open issues in the different theme repositories or mention them in comments further down.

I have contacted GitHub support for this, hopefully they will do something about it.

So I m giving this a rest until tomorrow.

@SamWhited: FWIW, and I know I'm probably in the minority here, I do not have a Twitter account.

Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way.

Thank you for your hard work, @onedrawingperday ! I'll fix my theme ASAP

@SamWhited

We are currently working on #668 and when that issue is resolved, we will put in writing that authors will need to keep an eye on current Hugo developments for making sure that a theme is functional with the latest version.

We always give theme developers a 30 day period for fixing issues and up until now I have been contacting people for problems out of my own time.

Breaking changes of the sort that happened in Hugo 0.57 are rare. Typically there is some kind of deprecation warning but in this case the changes in Pages Collections for the homepage etc. were done at once due to the development of new features like Cascading Front Matter.

@SamWhited: Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released?

@bep is the lead developer behind Hugo. He should know best if a stable release cycle can be established and how the roadmap of Hugo will look like (incl. deprecations in future releases.)

To cite him from https://github.com/gohugoio/hugoThemes/issues/678#issuecomment-521554768:

We could probably have dropped this home.Pages change, but since we had to introduce some other related breaking changes, I thought it was better to take all the pain at once ...

@onedrawingperday I just posted a tweet: https://twitter.com/GoHugoIO/status/1162382902937735168

The Universal theme is also suffering from the same issue.
Screenshot_2019-08-16_10-18-05

Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way.

Yes, contacting each developer individually doesn't seem sustainable. That's why I suggested a mailing list or blog, everyone can use RSS or everyone has an email, but not everyone has a Twitter. Email is universal, so in my mind it's probably the best place to start.

This may also just be me, but just from reading the docs on the where page and from this post and the issue, I don't actually understand how to fix my theme. You suggest where site.RegularPages "Type" "in" site.Params.mainSectionsbut that gives me a list of sections (whereas before my blog home page was showing a list of pages). Should I be paginating over all pages in all those sections? Should I still filter on a hardcoded type within those sections? I don't really understand how a blog that before was just displaying pages of type "posts" or some other hardcoded thing can be created using this new mechanism.

@onedrawingperday Thanks for informing, I'll fix my theme "Tikva" in the next days.

Kind regards,
Ralf

@SamWhited

I will look into your theme and let you know what you need to do in a bit.

@SamWhited

Apparently with the way that you have constructed your theme changing layouts/index.html does not make a difference.

To render the posts on the index page and every other list page you need to change line 2 of layouts/partials/header.html to the following:

{{ $pages := .Pages }}
{{ if .IsHome }}
{{ $pages = .Site.RegularPages }}
{{ end }}
{{ $paginator := .Paginate $pages }}

I have not used mainSections logic in your templates because this header partial is present everywhere.

@onedrawingperday thanks; I still don't understand what's going on here but maybe I'm just tired. I'll just make this change.

Oh, no, @onedrawingperday that doesn't appear to work. That now iterates over every single page on my site, not just blog posts or things in the mainSections list if I define it.

EDIT: Or am I supposed to apply the "type in mainSections" thing to that? I really don't understand why that logic would or would not be used because the header partial exists everywhere.

I believe I have fixed Den, but actually the demo seems a bit strange because some pages throw 404 errors. But I cannot reproduce this problem on my machine.

I don't fully understand this change, but I have fixed the XMin theme via https://github.com/yihui/hugo-xmin/commit/6123be24bf4a7517ae9cbf05882b62f52684d16d anyway. Thanks for notifying me!

@onedrawingperday thank you for notification! I will check mine.

I understand the desire to improve and sometimes choices needed to be made. However this breakage is a bit scary and not only affecting theme author. It is affecting end users.

Hugo is stable. As a hugo user, once I pick a theme and get my workflow straighten out, I almost never visit hugo forum again, and never have to update the theme. So there is no way I know the new version is breaking stuff. On Mac, I just did brew upgrade one day. Then once I run hugo again, the home page listing is gone. I spent like 2hr to pin point the issue and rolled back 0.56.3.

If you count people doing stuff on linux with automatic update or even with some kind of CI, it will be a big mess for many many people.

@SamWhited

mainSections are detected by Hugo internally and are arranged based on the number of content files within each section.

Therefore it was not needed to specify them in the exampleSite/config.toml

Your changes under /layouts/_default/list.html are fine.

Regarding the code block in /partials/header.html/ -as it is now- I will break it down and try to make it clear:

{{- if not .IsPage -}}
{{- $pages := .Pages }}
{{- if .IsHome }}
{{- $pages = .Site.RegularPages }}
{{- end }}
{{- $paginator := .Paginate (where $pages "Type" "in" site.Params.mainSections) -}}
{{- end -}}

Line 2: $pages := .Pages setting a variable that contains all Pages collection
Line 3: but check for homepage if .IsHome because:
Line 4: That variable needs to contain only .Site.RegularPages because this is the page collection for individual content pages for the homepage. Since Hugo 0.57 .Pages will render section and nested section list pages on the homepage.
Line 5: The logic in this line is wrong. You will get pages from every mainSection regardless of what belongs in a specific section list. It is preferable to have this line as it was written above i.e.:
{{- $paginator := .Paginate $pages -}} here $pages are the .Pages page collection which on section lists will behave as it used to (prior to Hugo 0.57) and it will return the content pages residing under each section.

If you prefer to use mainSections logic then it needs to be written like so:

{{- if .IsHome }}
{{- $paginator := .Paginate (where site.RegularPages "Type" "in" site.Params.mainSections) -}}
{{- end }}

Note that above you need to specify site.RegularPages and not $pages within the .IsHome condition because if you don't you will end up with a link to the section list Posts on your homepage.

So that the final code looks like this:

{{- if not .IsPage -}}
{{- $pages := .Pages }}
{{- if .IsHome }}
{{- $paginator := .Paginate (where site.RegularPages "Type" "in" site.Params.mainSections) -}}
{{- end }}
{{- $paginator := .Paginate $pages -}}
{{- end -}}

Hope I made this clear. I tested the above with your latest commit and on my end I get the homepage list to render as it used to be.

@onedrawingperday I still don't understand what mainSections is or how it works, but this does appear to show the right pages. Thanks.

@onedrawingperday My themes affected by this have been fixed

https://github.com/zwbetz-gh/papercss-hugo-theme
https://github.com/zwbetz-gh/minimal-bootstrap-hugo-theme
https://github.com/zwbetz-gh/cayman-hugo-theme

@SamWhited

The whole idea of mainSections is to make themes flexible for users. In your theme you use a /post/ section. Typically we see constructs like the following in themes:
{{ $paginator := .Paginate (where .Site.RegularPages "Type" "post") }}

And that is limiting end users because they may not want to use a /post/ section in their project but instead a /drawings/ section.

Before mainSections the end user would have to manually override the theme to make the paginator work like so: {{ $paginator := .Paginate (where .Site.RegularPages "Type" "drawing") }}

Since mainSections overriding is no longer needed because Hugo detects the top section internally and that is why for themes we recommend:
{{ $paginator := .Paginate (where site.RegularPages "Type" "in" site.Params.mainSections) }}

Anyway. There are further issues with your theme that are unrelated to this issue.

You will need to take care of these warnings at some point and before .Page.URL is deprecated:

WARN 2019/08/17 00:15:47 .File.Dir on zero object. Wrap it in if or with: {{ with .File }}{{ .Dir }}{{ end }}
WARN 2019/08/17 00:15:47 .File.TranslationBaseName on zero object. Wrap it in if or with: {{ with .File }}{{ .TranslationBaseName }}{{ end }}
WARN 2019/08/17 00:15:47 Page's .URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url.

The console messages are self explanatory. If you need help with these then please open a separate issue.

@onedrawingperday I don't even see those warnings if I run in verbose mode, where are you seeing that?

@SamWhited False alarm. Sorry I mixed up a log.

Anyway this wraps up your theme's issue. Once you push the suggested changes to the repo let me know so that I can mark your theme as fixed.

@onedrawingperday the theme has been updated and is fixed. I don't think I'm going to maintain this in the future though since this is the third or fourth time everything has been broken unexpectedly after a Hugo update, so I think I'll start looking for a more stable replacement. The theme does work for now, so feel free to keep it until the next major update or remove it as you prefer.

@SamWhited Since you do not intend to maintain this theme you shouldn't have wasted my time.

Your theme will be removed from this repo tomorrow.

Also do not contact me again.

acknowledging this, will probably go fix my theme tomorrow.

is there... a mailing list i should be on? proactively following hugo development is a very high bar to ask for. it sucks to have to chase down dozens of theme developers, but demanding dozens of theme developers chase hugo also sucks. we're all doing this for free, surely we can find a compromise. i'd be fine with getting pinged on an issue like we're doing here. is that what will happen in the future?

Running 0.57.1 which is supposed to have the fixed logic for mainSections, but I am still being forced to define it in the config.toml in order to have the pages show up. Lines 8-14 have been updated with Line 9 being changed to {{ $paginator := .Paginate (where site.RegularPages "Type" "in" site.Params.mainSections) }}

@shaform I confirm the fix. Also i plan to whitelist your theme so that there are no 404s.

However there are console warnings in your theme that you will need to address. The console messages below are self explanatory. If you need further help please open a separate issue:

 ==== PROCESSING  hugo-theme-den  ====== 
hugo-theme-den is whitelisted
Building site for theme hugo-theme-den using its own exampleSite to ../themeSite/static/theme/hugo-theme-den/
WARN 2019/08/17 09:04:02 Page's .Hugo is deprecated and will be removed in a future release. Use the global hugo function.
WARN 2019/08/17 09:04:02 Page's .URL is deprecated and will be removed in a future release. Use .Permalink or .RelPermalink. If what you want is the front matter URL value, use .Params.url.

@pacollins The problem you describe is related to the specific architecture of your theme. Please open a support ticket in the forum: https://discourse.gohugo.io/

cc: @digitalcraftsman

Note that on top of the GitHub user mentions limit that I have hit and mentioned above as of right now I can no longer edit the first comment of this GitHub issue to keep track of this issue's progress.

I have contacted GitHub support again but until I get a reply (which I haven't) I really can't do much, since at the moment GitHub makes it very hard for me to manage this issue.

cc: @digitalcraftsman @bep

@onedrawingperday many thanks for your time and effort. I will fix hyde-hyde and update soon.

@Leoj03 Thank you I have now tagged the author of the Universal Theme in this issue.

Thank you for letting us know about this, @onedrawingperday! I'll get to work on castanet. I noticed you mentioned https://github.com/gohugoio/hugoThemes/commit/863c6778b434733573cc1c1b243ca050bbc13845 - is this just an FYI or is it an problem?

is this just an FYI or is it an problem?

@mattstratton This is simply a reference for this repo. Please let me know once you issue a fix. Thanks.

Dear theme authors,

You may want to read the first post of this issue because unfortunately your theme is currently affected due to some breaking changes in Hugo 0.57.0

It was not possible to tag you in the original post due to GitHub's limit of 50 user mentions per post.

You will find all detailed instructions in the above link.
If you have any questions feel free to ask we will be glad to answer.

Affected Themes

  1. Silhouette @mattbutton
  2. Octopress @parsiya
    3. Bootstrap BP FIXED
  3. Hugo multi Bootswatch @mpas
  4. Er @lingxz
  5. Hugo Grapes @shankar
  6. Hugo Classic@goodroot
  7. Hugo Now @mikeblum
  8. Dark Simplicity @kritoke
  9. Internet Weblog @jnjosh
    11. Simple A FIXED
  10. Finite @lambdafu
  11. Rusty @cecyc
  12. Code Editor @aubm
  13. Hugo Cards @bul-ikana
  14. Phugo @aerohub
    Cocoa unmaintained
  15. Potato Dark @surajmandalcell
  16. AllinOne @orianna-zzo
  17. Basics @arjunkrishnababu96
  18. One @resugary
  19. Slim @zhe
  20. BeyondNothing @salcan
  21. Martial Paper @pedrodude
  22. Would have been cool in the 80s @pedrodude
  23. Sublime Hugo @dt801ts
  24. Classless @fiatjaf
  25. Landing Page @crakjie
  26. Bootie Docs @progrhyme
  27. Hugo Frais @the2ne
  28. Tracks @ageekymonk
  29. Phlat @nraboy
    33. Wave FIXED
  30. Paperback @dashdashzako
  31. onetwothree @schollz
  32. Casper @vjeantet
  33. Casper Two @eueung
  34. Simpledoc Theme @aerohub
  35. Elephants @meibenny
  36. Luxury Theme @aerohub
  37. Gentoo Theme @d-kusk
  38. Retroful Hugo @5ARMALE
  39. Liquorice @eliasson
  40. GitHub Project Page @nsomar
  41. Red Lounge @tmaiaroto
  42. AMP @pdevty
  43. Light Hugo @tblyler
  44. Hugo Geo @alexurquhart
  45. GoHugo AMP @wildhaber
  46. NeXT @leopku

Dear theme authors,

You may want to read the first post of this issue because unfortunately your theme is currently affected due to some breaking changes in Hugo 0.57.0

It was not possible to tag you in the original post due to GitHub's limit of 50 user mentions per post.

You will find all detailed instructions in the above link.
If you have any questions feel free to ask we will be glad to answer.

Affected Themes

  1. Hugo Scroll @fredrikloch
  2. Hugo Uno @fredrikloch
  3. Hugo Zen @rakuishi
  4. Heather Hugo @hbpasti
  5. Nixon @mdhender
  6. Darkdoc @adejoux
  7. Twenty Fourteen @jaden
  8. Angel's Ladder @tanksuzuki
  9. Hugo Bootswatch @imperialwicket
  10. Rocktopus @esell
    Gindoro unmaintained
  11. Projecthub @vjeantet
  12. Tachyons @marloncabrera
    Shiori unmaintained

@onedrawingperday My themes affected by this have been fixed.
https://github.com/guangmean/Niello

Should be fixed for
3) Bootstrap BP @spech66

Hi!

  1. Should be fixed in latest commit.
    Thanks for information.

On Sat, Aug 17, 2019 at 16:01, Alexandros notifications@github.com wrote:
Dear theme authors,

You may want to read the first post of this issue [https://github.com/gohugoio/hugoThemes/issues/682#issue-481516283] because unfortunately your theme is currently affected due to some breaking changes in Hugo 0.57.0

It was not possible to tag you in the original post due to GitHub's limit of 50 user mentions per post.

You will find all detailed instructions in the above link.
If you have any questions feel free to ask we will be glad to answer.

Affected Themes

  1. Silhouette [https://themes.gohugo.io/silhouette-hugo/] @mattbutton [https://github.com/mattbutton]
  2. Octopress [https://themes.gohugo.io/hugo-octopress/] @parsiya [https://github.com/parsiya]
  3. Bootstrap BP [https://themes.gohugo.io/bootstrap-bp-hugo-theme/] @spech66 [https://github.com/spech66]
  4. Hugo multi Bootswatch [https://themes.gohugo.io/hugo-multi-bootswatch/] @mpas [https://github.com/mpas]
  5. Er [https://themes.gohugo.io/er/] @lingxz [https://github.com/lingxz]
  6. Hugo Grapes [https://themes.gohugo.io/hugo-grapes/] @shankar [https://github.com/shankar]
  7. Hugo Classic [https://themes.gohugo.io/hugo-classic/] @goodroot [https://github.com/goodroot]
  8. Hugo Now [https://themes.gohugo.io/hugo-now/] @mikeblum [https://github.com/mikeblum]
  9. Dark Simplicity [https://themes.gohugo.io/darksimplicity/] @kritoke [https://github.com/kritoke]
  10. Internet Weblog [https://themes.gohugo.io/internet-weblog/] @jnjosh [https://github.com/jnjosh]
  11. Simple A [https://themes.gohugo.io/simple-a/] @AlexFinn [https://github.com/AlexFinn]
  12. Finite [https://themes.gohugo.io/hugo-finite/] @lambdafu [https://github.com/lambdafu]
  13. Rusty [https://themes.gohugo.io/hugo-theme-rusty/] @cecyc [https://github.com/cecyc]
  14. Code Editor [https://themes.gohugo.io/hugo-code-editor-theme/] @aubm [https://github.com/aubm]
  15. Hugo Cards [https://themes.gohugo.io/hugo-cards/] @bul-ikana [https://github.com/bul-ikana]
  16. Phugo [https://themes.gohugo.io/phugo/] @aerohub [https://github.com/aerohub]
  17. Cocoa [https://themes.gohugo.io/cocoa/] @nishanths [https://github.com/nishanths]
  18. Potato Dark [https://themes.gohugo.io/potato-dark/] @surajmandalcell [https://github.com/surajmandalcell]
  19. AllinOne [https://themes.gohugo.io/allinone/] @orianna-zzo [https://github.com/orianna-zzo]
  20. Basics [https://themes.gohugo.io/basics/] @arjunkrishnababu96 [https://github.com/arjunkrishnababu96]
  21. One [https://themes.gohugo.io/hugo-theme-one/] @resugary [https://github.com/resugary]
  22. Slim [https://themes.gohugo.io/slim/] @zhe [https://github.com/zhe]
  23. BeyondNothing [https://themes.gohugo.io/beyondnothing/] @salcan [https://github.com/salcan]
  24. Martial Paper [https://themes.gohugo.io/martial-paper/] @pedrodude [https://github.com/pedrodude]
  25. Would have been cool in the 80s [https://themes.gohugo.io/would-have-been-cool-in-the-80s/] @pedrodude [https://github.com/pedrodude]
  26. Sublime Hugo [https://themes.gohugo.io/sublime-hugo-theme/] @dt801ts [https://github.com/dt801ts]
  27. Classless [https://themes.gohugo.io/classless-hugo/] @fiatjaf [https://github.com/fiatjaf]
  28. Landing Page [https://themes.gohugo.io/landing-page-hugo/] @crakjie [https://github.com/crakjie]
  29. Bootie Docs [https://themes.gohugo.io/bootie-docs/] @progrhyme [https://github.com/progrhyme]
  30. Hugo Frais [https://themes.gohugo.io/hugo-frais/] @the2ne [https://github.com/the2ne]
  31. Tracks [https://themes.gohugo.io/hugo-tracks-theme/] @ageekymonk [https://github.com/ageekymonk]
  32. Phlat [https://themes.gohugo.io/hugo-phlat-theme/] @nraboy [https://github.com/nraboy]
  33. Wave [https://themes.gohugo.io/hugo-theme-wave/] @syui [https://github.com/syui]
  34. Paperback [https://themes.gohugo.io/paperback/] @dashdashzako [https://github.com/dashdashzako]
  35. onetwothree [https://themes.gohugo.io/onetwothree/] @schollz [https://github.com/schollz]
  36. Casper [https://themes.gohugo.io/casper/] @vjeantet [https://github.com/vjeantet]
  37. Casper Two [https://themes.gohugo.io/hugo-casper-two/] @eueung [https://github.com/eueung]
  38. Simpledoc Theme [https://themes.gohugo.io/hugo-simpledoc-theme/] @aerohub [https://github.com/aerohub]
  39. Elephants [https://themes.gohugo.io/elephants/] @meibenny [https://github.com/meibenny]
  40. Luxury Theme [https://themes.gohugo.io/hugo-luxury-theme/] @aerohub [https://github.com/aerohub]
  41. Gentoo Theme [https://themes.gohugo.io/hugo-gentoo-theme/] @d-kusk [https://github.com/d-kusk]
  42. Retroful Hugo [https://themes.gohugo.io/retrofulhugo/] @5ARMALE [https://github.com/5ARMALE]
  43. Liquorice [https://themes.gohugo.io/liquorice/] @eliasson [https://github.com/eliasson]
  44. GitHub Project Page [https://themes.gohugo.io/github-project-landing-page/] @nsomar [https://github.com/nsomar]
  45. Red Lounge [https://themes.gohugo.io/redlounge/] @tmaiaroto [https://github.com/tmaiaroto]
  46. AMP [https://themes.gohugo.io/amp/] @pdevty [https://github.com/pdevty]
  47. Light Hugo [https://themes.gohugo.io/light-hugo/] @tblyler [https://github.com/tblyler]
  48. Hugo Geo [https://themes.gohugo.io/hugo-geo/] @alexurquhart [https://github.com/alexurquhart]
  49. GoHugo AMP [https://themes.gohugo.io/gohugo-amp/] @wildhaber [https://github.com/wildhaber]
  50. NeXT [https://themes.gohugo.io/next/] @leopku [https://github.com/leopku]

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [https://github.com/gohugoio/hugoThemes/issues/682?email_source=notifications&email_token=AAPGBJ4VSR7U2MZ5XZY5BZ3QE7ZELA5CNFSM4IMFSTJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QKWZI#issuecomment-522234725] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AAPGBJ74SMCBOGYH5DMJBGDQE7ZELANCNFSM4IMFSTJQ] .

Thanks for the notification and the hard work you make @onedrawingperday!

38. Adam & Eve should be fixed! by https://github.com/blankoworld/hugo_theme_adam_eve/commit/e925bcdaba5017c526351e113ab0b8140e6fe2f3

Should I do something specific to include the changes in HugoThemes repository or update the ShowCase?

  1. hugo h5bp
    Unfortunately I have not stayed up to date with Hugo so I am not clear on the required changes. Maybe we should delist my theme?
  1. hugo h5bp
    Unfortunately I have not stayed up to date with Hugo so I am not clear on the required changes. Maybe we should delist my theme?

I've just taken a quick look at your theme. At the problematic line

{{ range first 10 .Data.Pages }}

you may try replacing .Data.Pages to .Site.mainSections, and see how it goes.

Please don't drop your theme. In case of doubt, you may ask in the Hugo forum.

@garvincasimir
If you want to maintain the theme on the list you can make the above change that @VincentTam proposed. The Hugo Support Forum is at: https://discourse.gohugo.io

Thank you for the response

Thanks for notifying me of this. I am a bit baffled by mainSections. I wanted to share the strange (at least to me) behavior.

In the index if I do:

{{ $pages := where site.RegularPages "Type" "in" site.Params.mainSections }}
{{ range $pages }}

All pages are rendered correctly and the range works. No pagination, of course.

However, if I paginate the $pages from the last example and range over its .Pages, I only get the Posts section:

{{ $pages := where site.RegularPages "Type" "in" site.Params.mainSections }}
{{ $paginator := where site.RegularPages "Type" "in" site.Params.mainSections | .Paginate }}
{{ range $paginator.Pages }}

I will spend more time on it this evening but in the meanwhile, I wanted to do a sanity check to see if I am doing something very wrong.

EDIT: I many of the commits and the helpful comments from onedrawingperday (hopefully this does not create another notification for you) helping someone resolve an issue but without mainSections. I'd rather use it to future-proof the theme.

The Hikari theme has been updated. See https://github.com/digitalcraftsman/hugo-hikari-theme/blob/master/CHANGELOG.md#release-v20---17th-july-2019

@parsiya mainSections logic was broken in Hugo v.0.57.0 and fixed v.057.

I just tested what you posted above in /home/alex/work/src/hugoThemes/hugo-octopress/layouts/partials/classic_index.html and with Hugo v.0.57.1 it works so if you commit these changes your theme should be good to go.

Thanks for your work in keeping the themes site updated, @digitalcraftsman and @onedrawingperday! I'll make whatever changes are necessary to fix Indigo in the coming week.

Theme authors: I've found it helpful to follow the RSS feed at https://gohugo.io/news/ to stay up-to-date on what's changing with Hugo!

Thanks @onedrawingperday, it's working now with v0.57.2. I have pushed a fix:

Thanks again @onedrawingperday. hyde-hyde is fixed as per htr3n/hyde-hyde@ad9701b

Thanks for notifying. The Bingo theme is updated: gundamew/hugo-bingo@ea9283f49a4d852127d013c9d25b962f7f7f4528

  1. Cocoa [https://themes.gohugo.io/cocoa/] @nishanths [https://github.com/nishanths]

I don't actively maintain the theme; it can be removed. Thanks for the notification!

  1. Now UI

Should now be fixed. @onedrawingperday Thanks for noticing this issue in the theme and letting me know, and thanks to others above for their examples of how to fix this.

  1. Twenty Fourteen

Should be fixed - jaden/twentyfourteen@89e9097208629a4b3f8c4318c5bf64eff73c7f71

  1. Elephants

Should be fixed with https://github.com/meibenny/elephants/commit/7c40d2c3737830b8fe4a1fe31a7795ae61209fdd.

Please let me know if there is any further action I need to take.

11.eiio @leonhe

Should be fixed with leonhe/hugo_eiio@cc47f865c3f8ca354cad651401569e0ead7601ac

37 kiss @ribice

Should be fixed with https://github.com/ribice/kiss/commit/925ce982d67456650904fed3279026691b3a76b1 (please confirm, not 100% sure about this).

@ribice I gave you feedback directly in commit ribice/kiss@925ce98
Once you make the changes please let me know. Thanks.

Updated per your comments. Thanks!

  1. Dream @g1eny0ung

Should be fixed with https://github.com/g1eny0ung/hugo-theme-dream/commit/dbf0c47b0e31a183c57142afb9b5d63fe2cefe8f

Thx for reminded. 😆

Have updated silhouette-hugo

Here's the commit: https://github.com/mattbutton/silhouette-hugo/commit/be305fbae0c401e8c574e38105d500096161d387

Thanks for the heads-up on this.

Hello All,
Thank you for the reminder and the kind guidance to fix this one.

Here goes my commit: balaramadurai/hugo-travelify-theme@65f7a10b7e6bd78eb539078cbf429d7d4b5dfdfb

Thanks and have a great day!
Bala

The herring-cove theme by Steve (spf14) will no longer be maintained. It has already been removed in https://github.com/gohugoio/hugoThemes/commit/e736afe719c75e47bf35bf322b59924374b540c4.

I fixed my theme(minimage) at this commit. https://github.com/d-kusk/minimage/commit/93a1f4b463388fd4791f59bb6c064976446ba352

But the list page with the specified category cannot be displayed properly. ( ex.) /category/hoge )
Please tell me how I can fix it.

@d-kusk Observe that in the code block in the top post, we loop over (a selection of) .Site.RegularPages only if it's the home page. For other pages, we loop over .Pages instead.

{{ $pages := .Pages }}
{{ if .IsHome }}
{{ $pages = .Site.RegularPages }}
{{ end }}
{{ $paginator := .Paginate $pages }}

@VincentTam
Thank you for teaching me. The syntax you taught me didn't work, so I tried to separate the templates and it worked.

fixed 4. Minimage.
https://github.com/d-kusk/minimage/commit/959ef80f49271f8e87dea5d2727fad7b455fd13e

  1. Hugo Dusk @gyorb

Should be fixed by https://github.com/gyorb/hugo-dusk/commit/b0d2bc7f46f07c8ffe1bd8b2ad3871603f52376d
Thanks for the review @onedrawingperday

@d-kusk Thanks for fixing the Minimage theme. What about the Gentoo Theme? Do you plan to update it also?

@onedrawingperday It will be updated as well. I think I'll do it next week at the latest, but should I hurry more?

@d-kusk No need to hurry. I just asked so that I know. Thanks for the reply.

Unrelated, but shout out to @onedrawingperday - you sir are awesome for managing this and assisting everyone. Thank you for what you do for hugoThemes!

@the2ne Thank you for the fix. Everything looks fine. 👍

  1. Pixyll @azmelanar

Theme is fixed with azmelanar/hugo-theme-pixyll@c25f5926822563d937b9df95be482fc5ed779b7c

Thanks

  1. Rusty @cecyc

Submitted a PR to remove my theme here.

  1. Dark Simplicity

Should be fixed in kritoke/darksimplicity@e00dc4177354bfced24d5679d954e5ff05d86357

@kritoke I gave you feedback in the above commit.

EDIT
I confirm that commit kritoke/darksimplicity@d516015 fixed everything. Thanks

The Nixon theme has been deleted by the author. I've removed it in d46f2d5642feeb1313bf08c3840e7323635709af

  1. Indigo

I believe this should be fixed per AngeloStavrow/indigo@a824342 — thanks again for the heads up!

  1. Gentoo Theme

I’m not going to update this theme.
Can you delete it from the list of themes?

I'm sorry if I've missed something in the issue's thread, but after changes in 0.57.x I wonder if we have to change minimum hugo version value in the theme config?

I've just got an user who had an earlier version (I don't know which one) and he claims that he got an error with can't evaluate field RegularPages in type *hugolib.pageState... After update to the latest version everything started to work again 😉

I wonder if we have to change minimum hugo version value in the theme config?

Yes you have to change it to "0.57.0"

Does this commit fix everything for hugo-grapes theme ?
shankar/hugo-grapes@af4af64

@shankar It looks OK. Thanks for the fixes.

  1. Paperback

Paperback theme should be fixed from dashdashzako/paperback@9b58ebac80f75ebc96421caa2b754fd088a11988.

@dashdashzako

I commented in linked commit please let me know again when you address my feedback.

@digitalcraftsman

Several authors have issued fixes, whenever you can please update the themes in the repo.

The themes have been updated.

I pushed a fix to https://github.com/lambdafu/hugo-finite/commit/105a665f19b3c5c94ea38681a671b4a15ef56b2e, but I admit that I am only making minimal changes and probably not keeping up with best practices. If anybody wants to adopt the theme, let me know.

My theme kiss was updated with suggested changes from @onedrawingperday, but it still seems to be buggy using the latest version of hugo (0.58.0).

https://www.ribice.ba/

The index page is not build correctly, the blog pages are fine.

I am away @ribice and cannot debug this at the moment.

In https://github.com/ribice/kiss/commit/7ea3147 you have hardcoded the mainSections parameter to "post" in your exampleSite’s config.

Do you have that section in your project?

By the way my advice above is that authors don’t need to specify the mainSections since Hugo detects them internally.

If one hardcodes mainSections in the configuration and what is entered in this array is not present in a project then there will be empty lists.

No I don't, and even after adding it the homepage is empty.

@ribice please open a support ticket at the Hugo forum: https://discourse.gohugo.io/

Also make sure to post a link with your project’s source code so that people can see what’s going on.

I might have a look later today but also I might not since I am away. Posting at the forum is your best bet.

@ribice I tested your theme's exampleSite with the latest Hugo 0.58.1 that was released today (6th Sep 2019) and everything is rendering fine on my end (i.e. the homepage features a list of posts)

The problem you mentioned above is not present in your theme, something else is going on with your project. If you need help ask in the Hugo forum.

@onedrawingperday
Thank you for notification. I fixed inkblotty theme, and it looks working fine with hugo 0.58.1.
Thanks.

@onedrawingperday made a minor update to https://github.com/salcan/BeyondNothing . Let me know if anything further is required and i'll dig into it. It's a very simple template so I never got too deep into the components, pagination etc. thanks

  1. Ezhil @vividvilla

Thanks for informing, I have fixed Ezhil on this commit - https://github.com/vividvilla/ezhil/commit/bb28e76551834a70f1889fb7601b49e5abd7e328

@vividvilla

Thanks for the fix. However there is no need to hardcode the mainSections parameter in your exampleSite’s config because you shouldn’t limit your users since mainSections are detected automatically. Also the HugoBasicExample that provides the demo content on the Hugo website does not have a “posts” section and your demo will still have an empty homepage as things are now. So please comment out the mainSections parameter from your config.

Please let me know when you do the above.

@onedrawingperday thanks for your prompt reply, I have made the required changes here - https://github.com/vividvilla/ezhil/commit/31544832ad07b4cb8984909b19a38e63147742eb

Friendly reminder to the theme authors mentioned in this issue.

In 2 weeks time themes that have not been updated for Hugo 0.58.0 will be removed from the Themes Showcase.

Please update your themes. If you have any questions then do not hesitate to ask.

Thanks! https://github.com/schollz/onetwothree fixed by @kartikynwa (https://github.com/schollz/onetwothree/pull/12)

The theme Hugo Nuo _might_ be fixed by an unmerged PR https://github.com/laozhu/hugo-nuo/pull/138.

Remarks: I've never tested it.

@VincentTam that PR looks OK, but there is nothing we can do unless @laozhu decides to update the Hugo Nuo theme.

I have submitted patches for the "Start Bootstrap Clean Blog" and "Universal" themes. Please note that I am not the owner of these themes, merely a user.

Last Call

Theme authors who are mentioned in the first post of this issue are kindly reminded to issue a fix for their themes by today the 30th of September @ 23:00 UTC (Coordinated Universal Time).

Themes without a fix will be removed from the Hugo Themes Showcase tomorrow


If you have any questions then please do not hesitate.

Unfortunately, this turned out to be a bit more effort than I had hoped (to update castanet by EOD today. There are some oddities that are showing up when I change the pagniator, and I have meetings all day today so I won't be able to make the deadline.

I respect the deadline and if you need to remove Castanet today I support this and will re-submit it in a few days once I get this resolved.

Apologies for dragging my feet on this one!

@mattstratton

You are more than welcome to re-submit your theme once it is fixed, as are all the other theme authors.

I have made the commit that closed this issue slightly earlier.

Thanks to all the authors who updated their themes.

@onedrawingperday Hi, I have a patch commit early to fixes this problem but I forgot to change the other paginator in layouts/index.html. So the Dream theme is still broken. I am sorry for my carelessness.

The early commit is https://github.com/g1eny0ung/hugo-theme-dream/commit/dbf0c47b0e31a183c57142afb9b5d63fe2cefe8f.

This commit should fix the problem. https://github.com/g1eny0ung/hugo-theme-dream/commit/29cfa530d6c5e230b1a076184ae41c8c47fd00fe.

If you are free, can you help me see if this solves the problem? Very thanks.

I already test it in my blog https://github.com/g1eny0ung/blog. Seems that all works fine. I re-submit in #717.

@onedrawingperday Hi, I have noticed that hugo changelog theme (https://github.com/jsnjack/hugo-changelog-theme) has been removed from the themes page. I have already created a fix and reported it here https://github.com/gohugoio/hugoThemes/issues/682#issuecomment-522241660 Do I need to change something else?

@jsnjack

Your theme was removed because its homepage rendered empty on the Hugo Themes showcase for reasons that are not related to this particular issue. See https://github.com/gohugoio/hugoThemes/pull/718 for the explanation.

Your theme has been re-added with https://github.com/gohugoio/hugoThemes/pull/718/commits/d6f2cf654929ccba0a6aa92d1d071190204f05ea once the deployment finishes it will show up again on the website.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

janraasch picture janraasch  Â·  3Comments

sakibccr picture sakibccr  Â·  6Comments

onedrawingperday picture onedrawingperday  Â·  7Comments

kskarthik picture kskarthik  Â·  7Comments

tomanistor picture tomanistor  Â·  7Comments