Hugothemes: New theme: Rusty

[cecyc]

Theme submission

Link to my theme repository: https://github.com/cecyc/hugo-theme-rusty

I made sure that...

• [x] the repository contains a good README.md describing my theme
• [x] an open source license has been added to LICENSE.md
• [x] all metadata have been added to theme.toml
• [x] screenshots have been added in the images/ folder with the required dimensions
• [ ] ~in case I'm using a customized demo via the exampleSite folder that~
  
  
  
  • [ ] ~https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains~
  
  
  • [x] the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  
  
• [x] I tested my theme against the gohugoio/HugoBasicExample
  
  
  
  • [x] I've checked the developer tools' console in my browser for error messages
  
  
• [x] in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

[onedrawingperday]

Hello @cecyc and thanks for your theme submission.

• In line 8 of your theme.toml you need to enter the valid URL of your theme's GitHub repository.

• In the thumbnail screenshot of your theme there is a white bar at the bottom. Please remove it.

Once you do the above let me know so that I can review your theme further.

Thank you.

[cecyc]

@onedrawingperday Hi, thanks so much for taking the time to review my theme.

Made the requested changes:

Fixed link to theme in theme.toml: https://github.com/cecyc/hugo-theme-rusty/blob/master/theme.toml#L8

Fixed tn.png (also added higher res screenshot): https://github.com/cecyc/hugo-theme-rusty/blob/master/images/tn.png

Let me know if you have any further feedback.

Thanks!

[onedrawingperday]

@cecyc

When I tested your theme with the Hugo Site Build Script I got the following console error:

 ==== PROCESSING  hugo-theme-rusty  ====== 
Building site for theme hugo-theme-rusty using config "config-hugo-theme-rusty.toml" to ../themeSite/static/theme/hugo-theme-rusty/
ERROR 2018/11/03 08:03:47 error: failed to transform resource: TOCSS: failed to transform "scss/style.scss" (text/x-scss): this feature is not available in your current Hugo version

To resolve this issue please have a look at the Resources section of the repository's README.

Once you commit the /resources/ folder along with its contents, let me know so that I can review your theme further.

Thanks.

[cecyc]

@onedrawingperday Hi there! Thanks for the feedback. I tested the site with the build script and it generated fine:

 ==== PROCESSING  hugo-theme-rusty  ======
Building site for theme hugo-theme-rusty using config "/var/folders/9b/ht4pmj8512b3kbpg8jps7g3c0000gn/T/config-hugo-theme-rusty.toml" to ../themeSite/static/theme/hugo-theme-rusty/

I was able to navigate to the theme page locally and run the demo site from the hugoThemes repo and didn't see any issues.

I added changed .Permalink to .RelPermalink as suggested here as you mentioned, but I did not see a public/resources folder generated.

I am only getting a public folder with the site (as normal), and resources is being generated at the root with a _gen folder. I uploaded both those folders to my theme repo, just in case, but I wasn't quite able to replicate the issue you're seeing :(

Updated repo is here, let me know if you're still seeing the issue. Very sorry about that!

[onedrawingperday]

@cecyc

I uploaded both those folders to my theme repo, just in case, but I wasn't quite able to replicate the issue you're seeing :(

It seems that you are using Hugo Extended and that's why you're not seeing the ERROR about the failure to transform resource: TOCSS. I'm using the Basic Version of Hugo on my system.

After committing the /resources/ directory your theme's demo generates fine with the Build Script on the Basic Version of Hugo and it can be used by any user who does not have the Extended version installed.

However now you need to remove the /public/ directory from your theme's repository because it's not needed.

Please do this and let me know.

Thanks.

[cecyc]

@onedrawingperday Hello! Went ahead and removed the public folder from the repo as you suggested. Let me know if there are any other changes.
Thanks!

[onedrawingperday]

@cecyc
Everything looks good with your theme now. 👍

@digitalcraftsman
This theme is ready to be added to the website.

[digitalcraftsman]

Hello @cecyc,

thank you for sharing this theme with the Hugo community. Your theme should be listed soon on the themes site.

Furthermore, I'll promote your theme on Hugo's official Twitter account.

[cecyc]

@digitalcraftsman Thank you! 🎉 😄