Hello @MunifTanjim,
thank you for sharing this beautiful, minimalistic theme with us :+1: The Hugo commnunity seems to keep me busy this week with requests to add their themes :wink:
Nonetheless, I build the theme site locally with Minimo and found this minor issues regarding linking assets and pages:
Always use relURL or absURL to build urls as in {{ "tags/" | absURL}} except for links that are generated by Hugo. In some cases, like your theme's demo on the theme site, websites are hosted in a subdirectory, e.g. www.themes.gohugo.io/theme/minimo. Currently you link every page/asset relative to the root directory so that the theme subfolder is omitted which results in a 404 error.
relURL and absURL take that into account. When linking pages and assets also make sure that your partial link doesn't start with a /. Otherwise those functions will make it relative to the root (by design). Here is an example of how the tags page can be linked: {{ "tags/" | absURL}} (note the missing / at the beginning).
I compiled a list of places where you should make use of the template functions:
But you shouldn't use them for links generated by Hugo. Hugo already processed the menu links so that they are relative urls by default. However, they begin with a / and in combination with abs/relURL the subfolder gets omitted again. Hence please remove absURL from here.
This comment got longer than intended. Otherwise your theme seems to look fine.
Cheers,
Digitalcraftsman
@digitalcraftsman , thanks for pointing out those mistakes :smiley: I've fixed them...
Thanks. I've added your theme to the list so should appear soon on the theme site. Furthermore, I'll promote your theme on Hugo's official Twitter account.
@digitalcraftsman, looks like I made another mistake :disappointed: I misspelled the theme's name in theme.toml. Is there any way to fix it? I've fixed that in my repo. Does Hugo Themes site sync with the theme repos?
Is there any way to fix it? I've fixed that in my repo. Does Hugo Themes site sync with the theme repos?
Themes are added as Git submodules. Those are references to commits in other repositories (the themes). They have to be updated manually. An update triggers a rebuild of the theme site.
But I ~can do~ did a manual update.
Can't there be some kind of corn job for pulling the latest commits of all those themes, maybe once a day? Just a suggestion.
Can't there be some kind of corn job for pulling the latest commits of all those themes, maybe once a day? Just a suggestion.
Sounds like a good idea and might be beneficial for theme maintainers a well.
See #259