Highlight.js: (swift) does not recognize core Apple foundational libraries

[AustinConlon]

I found this while writing this on Stack Overflow. I'm not sure what the root of the problem is, but I'm guessing it starts in the function signature. Here's the code:

func configuredGridCell() -> UICollectionView.CellRegistration<UICollectionViewCell, Emoji> {
    return UICollectionView.CellRegistration<UICollectionViewCell, Emoji> { (cell, indexPath, emoji) in
        var content = UIListContentConfiguration.cell()
        content.text = emoji.text
        content.textProperties.font = .boldSystemFont(ofSize: 38)
        content.textProperties.alignment = .center
        content.directionalLayoutMargins = .zero
        cell.contentConfiguration = content
        var background = UIBackgroundConfiguration.listPlainCell()
        background.cornerRadius = 8
        background.strokeColor = .systemGray3
        background.strokeWidth = 1.0 / cell.traitCollection.displayScale
        cell.backgroundConfiguration = background
    }
}

[joshgoebel]

Looks good to me... you need to tell it your code is Swift... otherwise it's auto-detected as ObjectiveC and that's obviously not doing what you wanted.

[joshgoebel]

Are all the same built-in classes equally valid in Swift as in ObjC?

  var API_CLASS = {
    className: 'built_in',
    begin: '\\b(AV|CA|CF|CG|CI|CL|CM|CN|CT|MK|MP|MTK|MTL|NS|SCN|SK|UI|WK|XC)\\w+',
  };

Right now Swift doesn't get any points for them while ObjC does which is why your code is being flagged as ObjC. (so many library mentions)

[AustinConlon]

you need to tell it your code is Swift

Since I encountered this as a Stack Overflow user, does this mean the question has to have the Swift tag?

[AustinConlon]

Are all the same built-in classes equally valid in Swift as in ObjC?

  var API_CLASS = {
    className: 'built_in',
    begin: '\\b(AV|CA|CF|CG|CI|CL|CM|CN|CT|MK|MP|MTK|MTL|NS|SCN|SK|UI|WK|XC)\\w+',
  };

Right now Swift doesn't get any points for them while ObjC does which is why your code is being flagged as ObjC. (so many library mentions)

There are a few new frameworks like WidgetKit which are Swift-only, but I'm not sure if that's part of the problem.

[joshgoebel]

Damn, my question was too broad. :-) All all the class prefixes listed there valid for use in Swift code also? I think you're saying the answer is yes?

I'm thinking we should add them to our Swift grammar so they can be highlighted and help out for auto-detecting, yes? Right now swift is highlighting them as "types" but they have no relevance score, so it doesn't make it more likely that your code is Swift like it would if we added those API classes as an explicit list.

[joshgoebel]

@AustinConlon Ping.

[AustinConlon]

Yup, all of the frameworks for those prefixes are Swift as well, none are exclusive to Objective-C.

[joshgoebel]

@AustinConlon Want to take a pass at making a PR to pull over that rule from Objective-C, and balance the languages out?

[AustinConlon]

Will do.

[joshgoebel]

And if you happened to have the time: https://github.com/highlightjs/highlight.js/issues/2819 :-)