Hero: Slow on iOS 11

[jvichub]

I'm testing a project on an iPad with iOS 11 beta, and transitions are slow, kinda choppy.

Is that a known issue? Anybody got any hints on what could I do?

The same project on a device with iOS 10 is running fine.

[AAAstorga]

Also on iOS 11, when transitioning from a collection view cell to a view controller, there is a brief flash of blackness.
This is as of iOS 11 beta 9

[iosdevben]

I'm getting a crash (SIGABRT) in HeroCoreAnimationViewContext.canAnimate when trying to present modal view controllers in Xcode 9 beta 6.

[JohannesSteib]

I'm encountering the same problem as @jvichub. Using iOS 11 beta 9 and Hero 0.3.6 the the transition between ViewControllers is flickering.
On iOS 10.3 it is working smoothly.

[mwhitt]

I'm experiencing the same flickering as @jvichub when defining a hero modal animation type to a navigation controller in iOS 11 GM. The modal transition works fine, the flickering happens when pushing or popping onto the nav controller.

[mwhitt]

Someone mentioned about needing better cleanup for custom modal transitions in iOS 11 but I was unable to find examples or more information. Does anyone else know what he is talking about and where to look in Hero?

[baims]

I'm having the same problem on iOS 11 when trying to push/pop into a UINavigationController. Same code is working fine on iOS 10.3.3. Any thoughts ?

[NikKovIos]

@baims Same problem(

[RayanSaeed]

Same problems here..

[jvichub]

I found out what was causing the slowdown was that I was doing a drop shadow operation on a UIView. I removed that and now it's back to normal.

[mwhitt]

I've added an example in a fork that demonstrates the custom navigation flash bug in iOS 11:
https://github.com/mwhitt/Hero

What is needed to re-create is a custom modal animation to a UINavigationController which sets the heroModalAnimationType. It also needs to hide the navigation top bar. Now anytime if you pop or push you will see a flash on iOS 11.

Another thing of note is this has to be run on a device. Running in simulator will not show the flash.

[NikKovIos]

Here is the bug in new ios with hero fade transition. The back button overlap another back button. In ios 10 everything was all right. First gif in iPhone5s. Second in iPhone7+.

In simulator there are no bugs.

[konroj]

Yeah, iOS11 & iPhone 7 flashes after several pushes in UINavigationController.
iPhone 6s with iOS11 works fine.

Update:

Fix in fork: https://github.com/konroj/Hero

changing _afterScreenUpdates_ to false did the thing on iOS11. self.fullScreenSnapshot = self.transitionContainer?.window?.snapshotView(afterScreenUpdates: false) ?? self.fromView?.snapshotView(afterScreenUpdates: false)

[wassimseif]

is anyone still getting this flashing effects? i updated to Hero 1.0.0