Hero: issue with heroID being updated inside collectionview cells

[imfractured]

I'm using IGListKit to show a set of collection cells. My cells are just squares with an image view. I use the image url as the heroID since its easy to track and dynamically update when a new image is set. It seems after an update has occurred, the subsequent hero animations are offset by the number of cells in the collection view that were inserted or added. You get a ghosting effect of two + cells animating back to their original positions when returning back from the presented view. Is there a way to clear out or nil a heroID or reset the cached mapping?

[lkzhao]

Can you check if the latest master fixes it? It might be related to https://github.com/lkzhao/Hero/issues/97

[imfractured]

Unfortunately its still happening, it seems like the heroIDs / objects are cached somehow even after prepare for reuse is called and the heroid is set to nil. Like #97 it only seems to happen when transitioning back to the previous view that presented the target controller. I can add a video or demo project if that may help? BTW Thanks so much for the excellent animation framework, its super slick!!!

[lkzhao]

Demo project would be nice!
On Sat, Feb 25, 2017 at 10:56 AM Nick Gorman [e-mail]
wrote:

Unfortunately its still happening, it seems like the heroIDs / objects are
cached somehow even after prepare for reuse is called and the heroid is set
to nil. Like #97 https://github.com/lkzhao/Hero/issues/97 it only seems
to happen when transitioning back to the previous view that presented the
target controller. I can add a video or demo project if that may help? BTW
Thanks so much for the excellent animation framework, its super slick!!!

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/lkzhao/Hero/issues/110#issuecomment-282492698, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADNEatsKF7aLFfHL7wRhHE2UU_7mnDcbks5rgE9FgaJpZM4MIC8J
.

[lkzhao]

Are you using the following to checkout the latest version:

pod "Hero", :git=>"https://github.com/lkzhao/Hero.git"

Cuz the newest version is not on the cocoapods spec yet.

[lkzhao]

Will close this for now. Feel free to reopen if you are still seeing the issue.