Helm-charts: Support fullnameOverride (Kibana chart)

Created on 30 Aug 2019  路  4Comments  路  Source: elastic/helm-charts

Describe the feature:

Currently "fullname" helper macro provides name to service, ingress etc. and it uses release name, chart name (and optionally you can input "nameOverride") and this results in a "x-y" construct.

Allowing the user to specify fullnameOverride in values file will give additional flexibility with naming resources.

Examples:

https://github.com/helm/charts/blob/master/stable/grafana/templates/_helpers.tpl
https://github.com/helm/charts/blob/master/stable/prometheus/templates/_helpers.tpl

Describe a specific use case for the feature:

I want my service, ingress and other resources to be named just "kibana", without any prefix, like "monitoring-kibana" (because they are anyway in the "monitoring" namespace in my case so it's redundant).

enhancement

Most helpful comment

I agree. My pod names are:

  • kibana-kibana-xxx
  • filebeat-filebeat-xxx
  • metricbeat-metricbeat-xxx

Please fix-fix

All 4 comments

This is inconsistent with elasticsearch's helm chart (which does not use the Release name at all--the service is always just named "elasticsearch-master").

I agree. My pod names are:

  • kibana-kibana-xxx
  • filebeat-filebeat-xxx
  • metricbeat-metricbeat-xxx

Please fix-fix

I'm closing this issue as it was implemented in #330

Thanks @tusciucalecs, you are a hero-hero!

Was this page helpful?
0 / 5 - 0 ratings