Helm-charts: [apm-server] Unused "fullnameOverride" parameter
Chart version: 7.6.0
Kubernetes version: 1.14.9
Kubernetes provider: EKS
Helm Version: 2.14.3
Describe the bug:
In apm-server helm chart, "fullnameOverride" doesn't work.
This parameter doesn't seem to be used.
In other helm chart, "fullnameOverride" works.
Got the following deployment name: "apm-server-apm-server"
Steps to reproduce:
helm install elastic/apm-server --name apm-server --set fullnameOverride="apm-server"
Expected behavior:
Deployment name should be "apm-server"
kawat55
All 3 comments
This is because there is no definition of fullnameOverride in _helpers.tpl. Only have to update that block.
{{- define "apm.fullname" }}
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- $name := default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-"}}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}
ralavay
on 18 Feb 2020
Hi @kawat55 @ralavay ,
Thanks for reporting this issue.
Do you think you could provide a PR to fix it?
jmlrt
on 5 Mar 2020
Added a PR #508.
kawat55
on 6 Mar 2020
Related issues
jmlrt
路
4Comments
naseemkullah
路
4Comments
melissajenner22
路
6Comments
jgato
路
7Comments
krichter722
路
6Comments
Most helpful comment
This is because there is no definition of
fullnameOverridein_helpers.tpl. Only have to update that block.{{- define "apm.fullname" }} {{- if .Values.fullnameOverride -}} {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}} {{- else -}} {{- $name := default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-"}} {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}} {{- end -}} {{- end -}}