Heidisql: Duplicate shortcut crashes Heidi

[cautionbug]

Steps to reproduce this issue

Possibly related to #733?

i did this from the initial launch dialog, no open connections. Call stack attached.

1. Open Preferences
2. Go to Shortcuts
3. Attempt to change or set a keyboard shortcut already in use.
   
   
   
   • Example: try setting "SQL > Reformat SQL" to Ctrl+Alt+F (by default assigned to "Various > Filter Panel")
   
   
4. First try sets the shortcut to (None)
5. Second try, crash:
   
   
   
   • Exception Class: EInvalidOperation
   
   
   • Exception Message: Cannot focus a disabled or invisible window.
   
   

Current behavior

Crash

Expected behavior

Any of these:

1. Kill operation - Shortcut already in use by "Other Thing". Force manual removal/reset.
2. Prompt: Shortcut already in use by "Label". Set here and clear "Other Thing"?
3. Prompt: Shortcut already in use by "Label". Set here and switch to "Other Thing" next?

Environment

• HeidiSQL version: 10.2.0.5683 (no newer nightly available)

bugreport.txt

[ansgarbecker]

I have now modified the shortcut editor to prompt the user if the wanted shortcut is in use by another action. So this is taken from your second idea from above:

But... this does not fix the crash you mentioned. It seems a pressed shortcut still triggers its assigned action before the shortcut editor handles it. I suppose I have to catch some message in this special dialog.

[cautionbug]

Thanks for the update! i like the confirmation message.

[ansgarbecker]

The next build now "suspends" the actions which listen to various shortcuts, as long as the preferences dialog is open. That should at least heal crashing shortcuts in the preferences dialog. I'll close this now, would be nice if you re-check once.

[cautionbug]

Clever bypass. i'll get the latest build and take a look. You do amazing work!

-- UPDATE --
Confirmed: i opened the Preferences dialog from the connection manager, changed some key shortcuts around, and got the message when there's a conflict.