Halflife: [CS 1.6] [Feature Request] sv_infinite_ammo

[Maxi605]

A server-side cvar to allow the use of infinite ammo on every weapon,

sv_infinite_ammo "1" to shoot infinitly.
sv_infinite_ammo "2" to be able to reload but the reload ammo never runs out.

Yes, this is a CS:GO feature but that doesn't mean that wouldn't be a good feature for CS 1.6

[metita]

There are a lot of QoL commands that should be added and are not that hard to implement (mostly for dev purpose).

[Maxi605]

There are a lot of QoL commands that should be added and are not that hard to implement (mostly for dev purpose).

What's QoL?

[metita]

*QoL = Quality of Life.* Makes your gameplay experience more easy and simple.

[Solokiller]

This would require each weapon to be updated since there is no common base class that handles ammo subtraction, and the cvar value would need to be networked to clients so weapon prediction works properly.

Since the crowbar bug fix would also require a cvar value to be networked this could add up pretty quickly once other cvars start needing it so it may be a good idea to come up with a way to network cvars independently of the weapons code. That would probably require a change to the network protocol though.

[afwn90cj93201nixr2e1re]

+1 we should fix client ammo field's too, coz there some of stupid limit's if we gonna set for example clip of m4a1 to 31 then reload animation gonna break, coz max clip is 30 on client, and it's hardcoded.

[Solokiller]

That would require all of the weapon info to be networked as well, which can't be done effectively within the restrictions of the current networking system.

Here's an example of the info that weapons have:
https://github.com/ValveSoftware/halflife/blob/c7240b965743a53a29491dd49320c88eecf6257b/dlls/mp5.cpp#L93-L108

And here's the M4A1's version:

int CM4A1::GetItemInfo(ItemInfo *p)
{
  p->pszAmmo1 = "556Nato";
  p->iMaxAmmo1 = 90;
  p->pszName = STRING( pev->classname );
  p->pszAmmo2 = 0;
  p->iMaxAmmo2 = -1;
  p->iMaxClip = 30;
  p->iSlot = 0;
  p->iPosition = 6;
  p->iFlags = 0;
  m_iId = 22;
  p->iId = 22;
  p->iWeight = 25;
  return 1;
}

[mikela-valve]

@SamVanheer I think infinite ammo could actually be done the slightly hacky way of just resetting the weapon ammo to max in CBasePlayerWeapon::UpdateClientData and the player's primary/secondary ammo to max in CBasePlayer::SendAmmoUpdate. Differences in ammo between the client and server are already synchronized so if this cvar gets set when the player has already fired the new amount would be synchronized on the next update and forcing the values to max before sending updates prevents the additional CurWeapon message that would be sent if the amount changed then changed back to max.

I concur 100% with you on actually changing the clip sizes or max ammo counts. Theoretically those should be adjustable through sending WeaponList messages that override the default values but unfortunately most of the weapons have hardcoded values for clip size or max ammo in them rather than using the values stored in the item/ammo info array, as you point out.

[Solokiller]

That should work as long as none of the weapons can use up all of their ammo in-between updates. Vanilla weapons don't do that but custom/modified weapons might do that.

Though perhaps there is an edge case where if a player sends an IN_ATTACK command and then no more commands, PreThink won't be called anymore and the weapon will run out of ammo eventually since it isn't calling UpdateClientData as a result.
But then the player probably won't be getting any updates to see this happen and will time out eventually anyway, so maybe that isn't an issue.

[mikela-valve]

Those are good points, I ended up doing it in ItemPostFrame after any handling of PrimaryAttack and Reload has already occurred, so it should always keep ammo counts at max regardless of what the player/server relationship is like. I tested with an M4A1 I forced to 1 round in the clip and everything worked as expected, so I'll include this in the next update.

[Solokiller]

That sounds good, but ItemPostFrame is called by CBasePlayer::PostThink which is also subject to the same rules as PreThink, namely it only runs when processing a user command. If the client isn't responding that won't be called either. SV_RunCmd in the engine handles all of that stuff.

[mikela-valve]

Yeah, I figured it would be best to see how it does with only the server handling infinite ammo before adding any support to the prediction for it. If there are reports that reasonable latencies are resulting in a long enough time between updates to cause the client to have issues I'll go into the prediction logic and add similar changes there.

[mikela-valve]

This is added in build 8303 as mp_infinite_ammo.
The settings for it match what @Maxi605 has above:
1 makes the weapon clip infinite
2 makes the weapon have infinite ammo for reloading

[Maxi605]

This is added in build 8303 as mp_infinite_ammo.
The settings for it match what @Maxi605 has above:
1 makes the weapon clip infinite
2 makes the weapon have infinite ammo for reloading

Works fine, thanks!

[agrastiOs]

@kisak-valve can be closed.

[CS-PRO1]

Just tested it, big thanks for adding this. Though I found that CS weapons aren't designed to have a spray pattern for more than their magazine capacity. For example, try shooting an M4 or AK for a few seconds and you'll notice that the weapon's spray will lock into 2 specific points and switch between them. I dunno if it's intentional but it doesn't make sense to do spray like that anyway..

[Solokiller]

It might be a good idea to implement this in all official games since the logic is pretty generic.

Also, the Deleted Scenes beta doesn't have this. Maybe the beta is out of date but it would be nice if it had this as well.

[Splatt581]

I think it would be nice to also add endless grenades for CS - if the player has grenades and the cvar mp_infinite_grenades 1, then they will be infinite. This would make it easier for players to train throwing grenades.

[afwn90cj93201nixr2e1re]

So, then we gonna get flashbang grenade bug's.

[agrastiOs]

Sv_infinite_ammo should give infinite grenades too instead.

[RauliTop]

Sv_infinite_ammo should give infinite grenades too instead.

Not agree with that, another new command will be better.

[mikela-valve]

@Splatt581 @RauliTop I’d actually already started on infinite grenades with that same cvar name a few days ago when I started looking into adding infinite ammo to all games as @SamVanheer suggested. It was actually when I got to TFC that I figured it would be good to be able to independently set infinite grenades since it could be a bit chaotic to always be able to throw grenades everywhere.

[mikela-valve]

I'm going to move this to future releases for the completion of mp_infinite_grenades and mp_infinite_ammo in all games due to each game having slight quirks to how ammo and grenades are handled so I want to give them a bit more time for testing. Infinite ammo for CS will be included in the next release.

[agrastiOs]

@kisak-valve Counter-Strike label should be removed.

[SmilexGamer]

I think it would be good to add a sprite (that is the infinity symbol, ∞) replacing the clip/ammo count when mp_infinite_ammo is 1 or 2 (the same goes for mp_infinite_grenades being set to 1).
With Half-Life's open source code, I made all weapons have their clip always set to 100 and then I replaced the clip count with an infinity symbol from Counter-Strike: Online.

Screenshots:

[SmilexGamer]

@mikela-valve it would be awesome if this feature (infinity symbol replacing clip/ammo count) becomes a real thing for all mods of Half-Life and Half-Life itself.