Habitica: Typos repository - errors in English text and suggested text improvements

[ghost]

edit by Alys, 22 May: new strings start at this comment: https://github.com/HabitRPG/habitrpg/issues/5631#issuecomment-226582108

An attempt to start a repository for typos in English text

Typos

• [ ] _not considered yet_: There is a space missing in front.json - marketing4Lead1 ...eachother... - as reported by bouncyballboy

• [x] Successully instead of SuccessFully in two lines (77-78) of settings.json - as reported (detachedFacebook and addedLocalAuth) on Transifex

  Style, commas, dashes, and other suggestions

• [ ] _not considered yet_: unwanted comma in npc.json - spellsText: You can now unlock class-specific spells. You'll see your first at level 11. Your mana replenishes 10 points per day[,] plus 1 point per completed

• [ ] _not considered yet_: unwanted comma in front.json - marketing3Lead2 ...you lose points when browsing unproductive websites[,] and gain points when on productive ones...
• [ ] _not considered yet_: hyphen/em-dash issues in the Community guidelines: elsewhere-we (spaces missing), several occurrences of --
• [x] question seems broken in challenge.json - sureDelCha - Delete challenge, are you sure? https://github.com/HabitRPG/habitrpg/pull/5818
• [x] In the challenges.json string "Max = #gems you own (+ guild.gems, if you created this challenge's guild)." no period is needed between "guild" and "gems" and maybe the string needs to be rewritten to sound more natural - as suggested on Transifex.
• [x] In the questsContent.json string "The Golden Knight shouts to the figure, "Father, no!" but knight shows no signs of stopping." it should be "the knight" or "the Iron Knight" - as suggested on Transifex by Shirviu
• [x] In the npc.json string there is an "a" missing; it should be: "Each time you level up, you get one point to allocate to a particular stat." as suggested on Transifex

• [x] In the front.json string "We all know how glued to phones and games students are these days, harness that power!" the comma before the word harness should be a semicolon - as reported on Transifex by @bouncyballboy.

  Not a typo

• With a final bellow questsContent.json#L195 (reported on Trello by RealBG, thanks to @Alys for clarification!)

• In the questsContent.json string "But rumor has it, if you feed them milk after midnight, they grow quite irritable." there should be no second comma between "midnight" and "they" - as suggested on Transifex
• In the front.json string "Bosses are "super accountability mode" - a day you miss the gym is a day the boss hurts" hyphen should be an emdash – as reported on Transifex by @bouncyballboy and @luveluen (we've decided not to change the dash)
• In the npc.json string "They appear here - use them to hatch pets!" hyphen should be an emdash – as reported on Transifex (we've decided not to change the dash)

[Alys]

I don't think "bellow" is wrong. The previous Stressbeast update spoke of the beast making a lot of noise, so going out with a final bellow makes sense. A bellow is a deep roar.

[ghost]

@Alys Thank you for clarification!

It seems I've added all the relevant comments marked as issues on Transifex. Could someone please review the items in the opening post and evaluate suggestions.

May I ask the moderators to feel free to edit the opening post if needed - as in a couple of days I'll be gone off-line for the next 2-3 weeks and won't be able to edit it.

[Alys]

"We all know how glued to phones and games students are these days, harness that power!" I'd change the comma to a semi-colon rather than a period.

"But rumor has it, if you feed them milk after midnight, they grow quite irritable."
I think the second comma between "midnight" and "they" is correct. It's separating a conditional clause from a main clause. http://dictionary.cambridge.org/grammar/british-grammar/conditionals ("Order of clauses" section)

[crookedneighbor]

I agree on both counts.

[crookedneighbor]

I'm updating the description of the original issue.

[dschur13]

I'm a new developer and wanted to help contribute. Is this issue being worked on by someone else currently?

[crookedneighbor]

Yes it is.

[hairlessbear]

@dschur13 https://github.com/HabitRPG/habitrpg/issues/4522#issuecomment-110843828 has some similar work that you could do.

[lemoness]

Quick confirmation that bellow is indeed intentional.

On Fri, Jul 17, 2015 at 11:53 AM, hairlessbear [email protected]
wrote:

@dschur13 https://github.com/dschur13 #4522 (comment)
https://github.com/HabitRPG/habitrpg/issues/4522#issuecomment-110843828
has some similar work that you could do.

—
Reply to this email directly or view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/5631#issuecomment-122372302.

[joedragons]

Maybe obvious but I think the first typo on your list has a typo.
"Successully instead of SuccessFully in two lines (77-78) of settings.json" I assume should be "Successfully instead..."?
Sorry if I'm confused. Hope that helps otherwise!

[sgabler]

I think the uppercase F was just meant to emphasise the change @joedragons. It should be Successfully, like you said

[crookedneighbor]

Closed with https://github.com/HabitRPG/habitrpg/pull/5759

[ghost]

A minor note for the sake of possible future reference before closing an issue reported on Transifex by CaffeineVelocity:

defaultTasks.json - defaultDaily3Text - 45m Reading
This is by no means an urgent matter, but the abbreviation for minute is "min".

The string is currently inactive (commented in content.coffee) as other default dailies and the issue is not urgent to fix what's not used ATM. However it may need to be changed/referenced if other strings will use #m format for minutes.

_UPDATE_ Thank you, Alys, for addressing it!

[Alys]

No no, it's 45 metres of reading. Line those books up! :)

We should probably delete those unused default Dailies. We can always get them back if we want them from version history. Thank you for mentioning it!

[ghost]

There's a comment on Transifex about a supposedly unneeded comma I've missed out previously. I have a feeling it's been discussed already somewhere, but I can't find it now. So I'm reproducing it here for consideration:
npc.json - spellsText:
You can now unlock class-specific spells. You'll see your first at level 11. Your mana replenishes 10 points per day, plus 1 point per completed

As reported by bouncyballboy:

The comma before the word "plus" is incorrect because the separated portions of the sentence directly correlate. It should be written "Your mana replenishes 10 points per day plus 1 point per completed[ task]".

[ghost]

• challenge.json - sureDelCha - Delete challenge, are you sure?
  As reported by Evropi:

  Would prefer something more like "Are you sure you want to delete this challenge?" I like the friendly tone of these strings, but broken English is unacceptable.

• front.json - marketing3Lead2 ...you lose points when browsing unproductive websites, and gain points when on productive ones...
  As reported by bouncyballboy:

  The comma in this part of a sentence should not have a comma

[ghost]

@Alys Hi! Posting here not having found the new right place for reports like the following one.
Reported by Jazzis18 on Transifex
questOctopusCompletion

Completion: With a final blow, the creature slips away...

_Completion is not needed both in the original line and in translations as it comes from Trello where it's used to indicate the text concluding a quest_

[Alys]

Thanks @GitHubSphinx and Jazzis18. I've made that change in the repo. It will go live in a few days.

[ghost]

Thank you!

[ghost]

_Fixed_

Reported on Transifex by @lyubomirv:

shieldSpecialSpring2015RogueNotes is supposed to be exactly the same as >weaponSpecialSpring2015RogueNotes however it has a typo:

Don't let the sound fool you - these explosives pack a punch. Increases Strength <%= str %>. Limited Edition 2015 Spring Gear.

"by" is missing in "Increases Strength <%= str %>."

[crookedneighbor]

Please submit a pr. I'll merge it right in.

[ghost]

Reported on Transifex by @lyubomirv:
gemButton says

You have <%= number %> Gems

even if number is 1

introduced with https://github.com/HabitRPG/habitrpg/pull/4733

[ghost]

Using this old thread as an external memory:

the following system message doesn't look natural:

Birds of Preycractination attack_s_ party for 0.0 damage

[ghost]

[Help wanted] Typos in new notifications/error messages reported to Transifex:

• [x] 'cardTypeNotAllowed' _Unkown_ _card type_
• [x] 'emailsMustBeAnArray' _Email invites must be_ _a an_ _Array._ - "a" is odd, why is Array capitalized, should anything be in quotation marks?
• [x] 'uuidsMustBeAnArray' _UUIDs invites must be_ _a an_ _Array._ - same as above

[Alys]

@GitHubSphinx Thanks! We'll fix these ourselves since we know what they're supposed to say. Feel free to add more here.

FYI, in programming, there are "data types", like Integer, Number, Array, Object. They're always capitalised when used in that specific meaning, so it's easy for a programmer to forget to stop capitalising when they're writing English. :)

[Alys]

fixed in https://github.com/HabitRPG/habitrpg/commit/fa009a19f4dd733ca8069df8068cc2ae5a3909b1

[ghost]

• [x] typo in noCompletedTodosChallenge 'Completed' is misspelled:

"includeComepletedTodos" is not supported when fetching challenge tasks.

Nice catch by @CAKS42 on Transifex

[ghost]

• [x] minor inconsistency in tip7:

Some backgrounds tile, like the Mountain Lake, Pagoda, Rolling Hills, Winter Twinkly Lights and Harvest Festival.

_Racobot_ The string in the Backgrounds resource is called "Pagodas", while here it's called "Pagoda" (note the 'S')

[Alys]

@GitHubSphinx I'll fix Pagodas tonight while I'm making another tips change, and do includeComepletedTodos at the same time.

Thanks to you and Racobot and CAKS42!

EDIT (not worth more email spam): Ah, Pagodas was already fixed in a previous tips change to remove the confusing "tile" terminology.

https://github.com/HabitRPG/habitrpg/commit/337cb22a9deb36777ac955a37724fab3d31c6312
https://github.com/HabitRPG/habitrpg/commit/514962a9c7be61b2e46ad3a4499b97d4e1a29dfe

[ghost]

• [x] Minor inconsistency pointed out on Transifex by @lyubomirv: out of 28 *UnlockText strings, 10 strings have pet name beginning with the first capital letter while 18 others mention pet without capitalization, for comparison:

Unlocks purchasable Cheetah eggs in the Market

Unlocks purchasable whale eggs in the Market

@Alys @Blade @lemoness would you consider this an issue?

[Alys]

I think it should be consistent and I think upper case is nicer. We'll wait a bit to see if there's any opinions for lower case.

[lemoness]

I also like upper case!

On Wednesday, June 15, 2016, Alys [email protected] wrote:

I think it should be consistent and I think upper case is nicer. We'll
wait a bit to see if there's any opinions for lower case.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/5631#issuecomment-226346086,
or mute the thread
https://github.com/notifications/unsubscribe/ADVQwdrsgW1aYGGdIJiVq4LzgxC6jEYOks5qMIXLgaJpZM4FZzCz
.

[ghost]

• [x] Another typo found by @lyubomirv in questFrogCompletion:

_"You can even see the tiny tadpoles and through the clear casing!"_ - aspiring quest writers have agreed that _"and"_ is odd here.

• [x] And another inconsistency with questAtom1Drop and questAtom2Dropmentioned in https://github.com/HabitRPG/habitrpg/issues/7629#issuecomment-225453537 (hasn't been addressed yet, as far as I understand)

_walderich_ There seems to be another inconsistency regarding the quest scrolls. They are usually suffixed with "(Scroll)", but The SnackLess Monster and The Laundromancer use "(Quest Scroll)".

@Alys thank you so much for fixing the previous typos!