Habitica: The sprites for some equipment can touch the knockout image in the death modal
OS: Windows 10
Browser: Google Chrome
User ID: ce3d1e2b-be53-4e5e-8101-273157548178
Example:
I'll open a pull request to fix this soon.
sporeball
All 35 comments
For possible reference, the latest changes were introduced with https://github.com/HabitRPG/habitrpg/pull/7156 (I don't know if this issue is actually related to those changes, but linking just in case)
ghost
on 29 Jun 2016
Accidentally tapped the button to close the issue on GitHub's mobile site, haha. We're not done yet.
@GitHubSphinx Looks like that issue just fixed some formatting with the text in the modal for the Russian translation. Thanks, though.
sporeball
on 29 Jun 2016
@Alys This looks like it'll require changing the size of one of the spritesmith-main spritesheets (to make the knockout image in the spritesheet bigger). Is it fine if I do that?
sporeball
on 1 Jul 2016
@MrEikono: Editing any of the spritesheets directly won't help, because those images will be overwritten the next time we compile sprites. You'll want to edit the knockout image itself, found in common/img/sprites/spritesmith/misc.
SabreCat
on 1 Jul 2016
I don't know why my pull request fixing #7197 and the pull request I sent to my fork of the HabitRPG repository to update it are referenced in #7752 , but if changing the knockout image itself is the only thing I need to do, #7752 adds 80 pixels of width to the knockout image, which looks it like it should be enough.
sporeball
on 2 Jul 2016
Just changed the width of the knockout image again in 7b9a340. Here's a screenshot -
sporeball
on 3 Jul 2016
@lemoness, what do you think?
SabreCat
on 4 Jul 2016
That might be a little too far to the right. How does it look over the user's head?
lemoness
on 8 Jul 2016
@lemoness Does this look okay?
sporeball
on 11 Jul 2016
Don't mind the 30 or so new commits in #7752 , I'm just bad at rebasing apparently
sporeball
on 12 Jul 2016
@MrEikono for what it's worth it feels that some pieces of head gear might touch the knockout image if it's placed above the head like that. You may want to test the Shade Helm for example, Flame of Mind or Crown of Tentacles
ghost
on 12 Jul 2016
...I only just now got the joke inherent to "Flame of Mind".
I'm slow. Like, two years slow, apparently.
SabreCat
on 12 Jul 2016
I guess you just weren't in the right frame of mind for it ;)
But yes, I think that many of the helms will unfortunately overlap.
On Tuesday, July 12, 2016, Sabe Jones [email protected] wrote:
...I only just now got the joke inherent to "Flame of Mind".
I'm slow. Like, two years slow, apparently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/7738#issuecomment-232076642,
or mute the thread
https://github.com/notifications/unsubscribe/ADVQwT1Jr9vjD1kbTR3qRCIvUZo8gkm5ks5qU60UgaJpZM4JAoLq
.
lemoness
on 13 Jul 2016
Oh.... frame of mind.... I TOTALLY got that after Sabe's comment and didn't have to wait for Lemoness's reply AT ALL. :blush:
Alys
on 13 Jul 2016
Fixed the fork. Testing various pieces of head gear now.
sporeball
on 14 Jul 2016
Even the Shade Helm doesn't overlap with this setup. (Is the knockout image too close to the health bar now, though?)
I'll have to adjust the dimensions of the knockout image accordingly if this is fine, so we won't have to use any top or left values on .knockout, but here's what I did in Chrome's developer tools:
Quick question, though - how do I get the backer-only items as equipment in my inventory when using Habitica locally? I had to change the style for the element for the head gear to this just to get it to show up and be centered correctly:
sporeball
on 14 Jul 2016
Hm. How does it look in that position with a variety of different helms
(and no helm at all)? Having a variety of equipment in the mockups will
make it easier to see what looks best overall.
On Wed, Jul 13, 2016 at 10:07 PM, MrEikono [email protected] wrote:
Even the Shade Helm doesn't overlap with this setup. (Is the knockout
image too close to the health bar now, though?)I'll have to adjust the dimensions of the knockout image accordingly if
this is fine, so we won't have to use any top or left values on .knockout,
but here's what I did in Chrome's developer tools:[image: image]
https://cloud.githubusercontent.com/assets/12767408/16828457/c05d4338-4944-11e6-9eb1-21d11d53bd45.pngQuick question, though - how do I get the backer-only items as equipment
in my inventory when using Habitica locally? I had to change the style for
the element for the head gear to this just to get it to show up and be
centered correctly:[image: image]
https://cloud.githubusercontent.com/assets/12767408/16828505/2095ff74-4945-11e6-83b7-2811d4d6ee08.png—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/7738#issuecomment-232557862,
or mute the thread
https://github.com/notifications/unsubscribe/ADVQwdO-0MCKWUG14vqv5nIVTwdb-AV9ks5qVcQcgaJpZM4JAoLq
.
lemoness
on 16 Jul 2016
@lemoness I'll be at my computer a bit less until Thursday, but I'll try to find some time to test with as many helms as possible. 😊
sporeball
on 16 Jul 2016
Ended up being a bit more busy than I thought I would be, but I'm testing every helm as I write this. And:
@lemoness I'm a bit skeptical about moving the knockout image even higher than in the screenshot with the Shade Helmet, because then it would be really, really close to the health bar; what do you think about that?
_Edit:_ Looks like the only helms that come into contact with the knockout image when it's put at the position shown a few comments ago are the Crystal Crescent Helm (above) and the Marching Bard Hat:
The Cat Hats come pretty close but don't touch the knockout image.
Here's an imgur gallery with a few different helms, as requested.
sporeball
on 22 Jul 2016
the off centered knockout animation with some of the hats makes it look a little strange. It is unfortunate that we do not have more space to separate the two because if it was higher above it would be more distinct and centering wouldn't matter as much I feel like.
audiolion
on 22 Jul 2016
It's turning out to be tougher than expected to get something that looks
good consistently. Some other options we can try:
- two knockout sprites on either side of the avatar, out of weapon/shield
range - a knockout sprite ABOVE the health bar, separated from the avatar
On Fri, Jul 22, 2016 at 12:33 PM, Ryan Castner [email protected]
wrote:
the off centered knockout animation with some of the hats makes it look a
little strange. It is unfortunate that we do not have more space to
separate the two because if it was higher above it would be more distinct
and centering wouldn't matter as much I feel like.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/7738#issuecomment-234635472,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADVQwQbTXlxwZgoenrtjgXgR5zY0oeNOks5qYRsLgaJpZM4JAoLq
.
lemoness
on 26 Jul 2016
Knockout sprite above the health bar:
Maybe two knockout sprites could look something like this:
I also tried putting the knockout sprite under the avatar:
sporeball
on 30 Jul 2016
I think the double icons look the best! It also matches the way double achievement icons are shown in achievement modals.
khipkin
on 2 Aug 2016
@lemoness Which one should we go with?
sporeball
on 3 Aug 2016
I also like the double knockout, for the same reason. Let's go with that
one.
On Tuesday, August 2, 2016, MrEikono [email protected] wrote:
@lemoness https://github.com/lemoness Which one should we go with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/7738#issuecomment-237112569,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADVQweNsHg-tWXKBFLfFil3k2tPB7jOgks5qb_iogaJpZM4JAoLq
.
lemoness
on 4 Aug 2016
I'm probably just being a complete idiot right now, but I can't figure out how to make a single sprite with two knockout faces work without using extra CSS values... Is using extra CSS values even viable?
sporeball
on 9 Aug 2016
@MrEikono: Additional CSS is okay. The CSS that's there is a bit of a mess of inline styles, too, so if you see opportunities to standardize things / make classes, go for it.
SabreCat
on 9 Aug 2016
I'm unable to compile sprites to test the changes I've been making recently, so I'll continue fixing this issue as soon we figure out a solution to that problem.
I just opened #7915 for the problem with compiling sprites.
sporeball
on 19 Aug 2016
Okay, so I'll finally have a decent chunk of time to get back to this issue tomorrow on October 10.
Sorry for the insane delay guys. ;_;
sporeball
on 8 Oct 2016
...
So, the chunk of time from earlier got negated because of git merge conflict nonsense. Sorry, people who reacted with confetti.
However! I have a break from school for the next week! Hopefully I can use this time to get. this. issue. done...!!
sporeball
on 20 Nov 2016
I'm putting this on hold because we're most of the way through a project to change the website's front-end code and this might no longer happen afterwards, or if it does, there'll be new code that will need to be modified to fix it.
Alys
on 24 Jun 2017
Is this still an issue?
lemoness
on 19 Oct 2017
oh gosh i completely forgot Habitica was ever a thing (and, accessorily, this problem)
i'm so sorry 😞
i'll get my act together and check very soon
sporeball
on 19 Oct 2017
looks like this is no longer a problem since the knockout image isn't in the death modal anymore.
what is an issue is that my costume now slightly touches this circle
but that's a new issue, so i guess i'll close this one
sporeball
on 19 Oct 2017
Thank you very much!
On Wed, Oct 18, 2017 at 6:07 PM, MrEikono notifications@github.com wrote:
looks like this is no longer a problem since the knockout image isn't in
the death modal anymore.
what is an issue is that my costume now slightly touches this circle
[image: image]
https://user-images.githubusercontent.com/12767408/31749473-149d42a8-b42f-11e7-8edb-3acefcef6888.png
but that's a new issue, so i guess i'll close this one—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitica/issues/7738#issuecomment-337770347,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADVQwazd9IAb4Qjm0563qDgRUw0BPez2ks5stqC-gaJpZM4JAoLq
.
lemoness
on 19 Oct 2017
Related issues
Frownigami1
·
4Comments
Alys
·
4Comments
mikean92
·
3Comments
aksteele
·
3Comments
Alys
·
4Comments
Most helpful comment
Oh.... frame of mind.... I TOTALLY got that after Sabe's comment and didn't have to wait for Lemoness's reply AT ALL. :blush: