Habitica: "Your private messages have been marked as read"
General Info
- UUID: 553bd048-0d10-4a47-835a-21eff8f35c55
- Browser: Most recent version of Firefox
- OS: Windows 8.1 64-bit
Description
When I check my inbox, like eight or so of these popup messages show up, and they sometimes continue to show up if I go to other tabs like Party.
http://i.imgur.com/EO4aLkV.png
http://i.imgur.com/Zk3LLwC.png
Console Errors
onlyforhabitica
All 9 comments
Confirmed. I saw it once when accessing my inbox this morning (which is expected and currently the intended behaviour), then twice when I was leaving the inbox.
I think we should get rid of that message altogether on the website; it's good to return it from the API. In the website, it's not helpful and typically too many messages make people blind to all messages.
Alys
on 31 May 2016
Is there a different way to implement the feature that would be more similar to other chat platforms? Example: If a message has been read, you see a checkbox somewhere
quin-jay
on 1 Jun 2016
@lynnyliz From past experience, it seems to turn the messages that are read grey
librarianmage
on 2 Jun 2016
This is still happening for me. Everytime I access my inbox I get 6-8 messages on the side that my "private messages have been marked as read". Even when there was only one message to read. Even when there were no unread messages and I merely navigated there to reply to someone or re-read a message for info. And they all pop-up again when I navigate away to a guild, to my tasks, or to my party. If I then hit refresh, they all pop-up one more time, but then seem to be finished notifying me ... until the next time I visit my inbox.
LlamaHobbit
on 6 Jun 2016
@Alys Why you do you consider it useful for the api to return the message? In case the third party wants to display it?
Currently the api docs don't specify this return value and ignoring it in normal operation would require hardcoding in either callOpsFunctionAndRequest or the op itself. Or extra parameters. Nothing as nice as removal.
Is the API frozen?
lynxlynxlynx
on 19 Jun 2016
It's not necessary on the website because you can see that your messages have been read. However if you're marking them as read using an API call, you might not have the same visual feedback and so it's beneficial to pass back a clear message. Bu if it's not possible to hide the message on the website while still returning it for all other API calls, then we should show it on the website too (but only once).
The API isn't frozen, but we need to be cautious about making changes that adjust its current behaviour.
Alys
on 19 Jun 2016
But in this case the call is only setting a var and returning it. Even if that can somehow silently fail, one could still check the return value [0]. Another option is to pass an empty string if the op was a noop. That would also skip all the duplicates.
lynxlynxlynx
on 19 Jun 2016
That's the cleanest option, so I'm pretty happy with it. RFC
lynxlynxlynx
on 19 Jun 2016
This is fixed with https://github.com/HabitRPG/habitrpg/commit/941ff10cdceb59313d575aa6362844fc4ff2e93f, will go out with the next deploy.
crookedneighbor
on 19 Jun 2016
Related issues
Alys
路
4Comments
Alys
路
3Comments
Alys
路
4Comments
kantamablade
路
4Comments
Alys
路
4Comments
Most helpful comment
Confirmed. I saw it once when accessing my inbox this morning (which is expected and currently the intended behaviour), then twice when I was leaving the inbox.
I think we should get rid of that message altogether on the website; it's good to return it from the API. In the website, it's not helpful and typically too many messages make people blind to all messages.