Habitica: backgrounds Check-In prize has no name in the notification modal

[Alys]

The check-in prize for your second day in Habitica is a set of backgrounds. When you're given that prize, the modal does not show the name of the prize:

It should show the name in a way similar to this:

I expect that this is because the backgrounds aren't content in the same sense at the other prizes so the code can't fetch their name.

One possible fix would be to hard-code a name into website/common/script/content/loginIncentives.js in a new field called something like rewardName (the value should be translatable of course). That field would be used for only the backgrounds (but could be reused in future if we needed to give a custom name to any other prizes). The code that inserts the name into the modal could first look for the rewardName and if it's not specified, it could then fetch the name from the content in the same way it currently does.

_After this is fixed for the website, we should test the Android and iOS apps to see if they pick up the fix automatically (I'm not sure whether the name lookup happens in the API or in the apps). Currently in the Android app, the backgrounds are described as "null"._

[citrusella]

Should it be noted that the equipment rewards don't seem to load the right name in Android either? The first (the thing in the bard set) actually reads armor_special_bardrobes (or something like that) instead of its actual equipment name. (Or at least it did on the account I just made to play around and look.)

[Alys]

@citrusella Ah, great point. I did notice that but it just didn't occur to me to report it :man_facepalming: It's a separate problem though and I've reported it here: https://github.com/HabitRPG/habitica-android/issues/708#issuecomment-287512698

[Yutsuten]

@Alys I would like to work on this issue, may I?

[Alys]

@Yutsuten Please do! Thanks!