Habitica: Flower not appearing on avatar transformed with shiny seed; unsure if this is intended behavior

[citrusella]

General Info

• UUID:
• Browser: Firefox
• OS: Windows 7 (via Bootcamp on a Macbook Pro)

Description

Didn't include my UUID because it's apparently happening to everyone (according to discussion in the Tavern), but the hair flowers aren't appearing on flower-transformed avatars. I didn't know if this was an intended change (especially since the wiki still mentions flowers as being the only things flowers can wear), so I figured I'd log it.

Expected behavior is outlined here: http://habitica.wikia.com/wiki/Transformation_Items#Shiny_Seed

I could understand this being something it's not worth it to "fix" (if it's actually unintended), but I figured I'd bring it up.

Console Errors

None.

[Alys]

The new behaviour is more consistent from a coding point of view (the avatar transformation buffs are meant to override everything on the avatar), and it probably came about when the code was refactored (i.e., the original behaviour might have been a bug) but I'd really like to see the original behaviour brought back if it can be done without too much unpleasant code. When the Shiny Seeds were first introduced, there were several amused comments in the Tavern about the flower-on-flower effect, and it adds a little bit of extra adorable quirkiness to Habitica.

However nothing should be done about this until API v3 is released to avoid code conflicts. I'm marking this as "wait".

[librarianmage]

Would I be able to work on it now?

[Alys]

@lemoness Is it okay if this is changed to put back the adorable winking flower effect? :)

[lemoness]

Yes :)

On Tue, May 31, 2016 at 4:24 PM, Alys [email protected] wrote:

@lemoness https://github.com/lemoness Is it okay if this is changed to
put back the adorable winking flower effect? :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/7133#issuecomment-222850698,
or mute the thread
https://github.com/notifications/unsubscribe/ADVQwSGs8LAM_Ddv08nvtrBlO6eCFkhhks5qHMM7gaJpZM4IThXq
.

[Alys]

@MathWhiz Feel free to start if you still wish to!

[librarianmage]

Ok! (I already did it ;) )
On Fri, Jun 3, 2016 at 9:28 PM Alys [email protected] wrote:

@MathWhiz https://github.com/MathWhiz Feel free to start if you still
wish to!

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/HabitRPG/habitrpg/issues/7133#issuecomment-223731147,
or mute the thread
https://github.com/notifications/unsubscribe/ALz_89ALLhbY6RvgMYXorKZA1yLBV46Vks5qIOLdgaJpZM4IThXq
.