Gutenberg-mobile: [Android] Multiple media selection adds only one image/video block

Created on 3 Sep 2019  路  1Comment  路  Source: wordpress-mobile/gutenberg-mobile

Current behavior:

  • Add an image/video block
  • Add multiple images/videos from WordPress media library
  • Only 1 image/video block is added

Expected behavior:

  • Add an image/video block
  • Add multiple images/videos from WordPress media library
  • Multiple image/video blocks are added with the selected images/videos

Root cause analysis

It looks like we are having a side effect of a recently merged PR. The code that subscribes for mediaAppend events are moved and since inserter menu is not rendered after we pick the media it won't be able to listen. We can try moving this subscription back to its old place as a solution, or anywhere more suitable which won't be unmounted along the way.

This is only observable via WordPress Android app because WordPress iOS app doesn't let multiple selection on WordPress media library currently.

[OS] Android [Type] Bug

Most helpful comment

This also seems to be the cause of an issue on WPiOS, where the Force Touch app shortcut doesn't work properly selecting "New Photo Post".

Steps:

  • Force Touch on the WPiOS app icon.
  • Select New Photo Post shortcut.
  • Make sure Gutenberg was opened as the editor.
  • Select an Image.
  • 馃挜 No image block was appended.

Force_touch_bug

>All comments

This also seems to be the cause of an issue on WPiOS, where the Force Touch app shortcut doesn't work properly selecting "New Photo Post".

Steps:

  • Force Touch on the WPiOS app icon.
  • Select New Photo Post shortcut.
  • Make sure Gutenberg was opened as the editor.
  • Select an Image.
  • 馃挜 No image block was appended.

Force_touch_bug

Was this page helpful?
0 / 5 - 0 ratings