Gutenberg-mobile: List block

Created on 29 Oct 2018  路  9Comments  路  Source: wordpress-mobile/gutenberg-mobile

Add support for the list block.

I don't know the difficulty of implementing the indent and outdent buttons, but I'd be fine leaving those out of the beta. I don't see anything else on the web version to leave out.

List-related issues:

  • [x] Editor crash when undoing at list end #836
  • [x] List crashes with extra spaces #871
  • [x] List block split: item and caret at wrong lines when nested lists #886
  • [ ] ~List block split problem with nested lists~ #874

Not blockers:

  • [ ] ~List Block Ordered list number indicators don't respect alignment~ #846

Strikethrough items are let to have a life of their own (see https://github.com/wordpress-mobile/gutenberg-mobile/issues/208#issuecomment-489232141).

Blocks

Most helpful comment

Let's keep this open until we have nested lists, and the implementation is solid enough to enable on production builds.

All 9 comments

This was estimated at 1-2 weeks by @daniloercoli, but as @diegoreymendez pointed out, we were not accounting for nested lists. Hopefully those are easy, but they aren't as critical for the beta, so we'll count 2 weeks per platform for this task and re-evaluate when we know more

Known issues after https://github.com/wordpress-mobile/gutenberg-mobile/pull/704:

Issue #845: caret positioning when new item at the end

  1. Do a long list, long enough to have a few empty list items here and there
  2. Try to add a new item at the end of the list
  3. Notice that the caret doesn't land on the new list item but rather, goes "back". The more empty lines from 2., the more chars the caret goes back.

Issue #846: Ordered list number indicators don't respect alignment when adding a new item to the end of the list

  1. Do a long list (> 10 items in the list)
  2. Try to add a new item at the end of the list
  3. Notice that number indicators < 10 don't respect alignment until you type something in the item
    list-android

Issue #836: Undo sometimes crashes on multi-line lists

  1. Create a new list
  2. Add a line
  3. Press enter and add another line
  4. Click undo

Let's keep this open until we have nested lists, and the implementation is solid enough to enable on production builds.

To avoid cluttering the 2.0 Bugs column, I started a checklist on this issue with all the list-related bugs. Please keep adding there as you find them. When this is ready for production, let's make sure any remaining items have a card in the project

Just added my notes from a quick design review on the current (as of the current WPAndroid alpha) list block: https://github.com/wordpress-mobile/gutenberg-mobile/issues/897

Added a minor issue related to caret positioning when splitting list items: #929

Bumping this to the next milestone.

Since we're shipping lists for both platforms in 1.4, and we have individual issues for every known bug, I think we can close this one?

Will strikethrough the non-checked items in the ticket and will leave the individual tickets to have a life of their own 馃憤 .

Was this page helpful?
0 / 5 - 0 ratings