Guake: tab save fails on splitted terminal (DualTerminalBox)

[gsemet]

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/guake/utils.py", line 82, in wrapper
    g.save_tabs()
  File "/usr/local/lib/python3.5/dist-packages/guake/guake_app.py", line 1162, in save_tabs
    'directory': page.child.terminal.get_current_directory(),
AttributeError: 'DualTerminalBox' object has no attribute 'terminal'

[gsemet]

@mlouielu can you look at this, look like split terminal is not fully supported by tab session save :)

[mlouielu]

Yep, I'm trying to implement split save/restore now

But I remember it still will store the first terminal (or last focus, I
guess) in current version

[mlouielu]

Here is the WIP: wip-save-restore-terminal-split

[gsemet]

ok

[mlouielu]

After testing now, an DualTerminalBox will block save_tabs... I'll make it work ASAP, should be considered as a defect.

[mlouielu]

@gsemet Can you take a test on wip-save-restore-terminal-split?

Please test with 5+ page, with 2 pages have more than 8 split terminals. Then do multiple restore tabs to check if the terminal spawn has hung up (like the figure). thanks.

For Gtk-CRITICAL, I've opened an issue on VTE

[gsemet]

Ok I'll check it tomorrow

[gsemet]

Confirmed: your fork seem to support splitted screen pretty fine :)