Graphql-flutter: multipart_upload_test fails

Created on 6 Jan 2020  路  6Comments  路  Source: zino-app/graphql-flutter

Describe the bug
graphql/test/multipart_upload_test fails at line 161 because application/json is returned instead of multipart/form-data.

To Reproduce
Steps to reproduce the behavior:

  1. cd graphql-flutter/packages/graphql
  2. pub run test_coverage
  3. Interrupt as soon as .test_coverage.dart is generated.
  4. Run test manually using:
    dart --pause-isolates-on-exit \
    --enable_asserts \
    --enable-vm-service=8787 test/.test_coverage.dart

The relevant section of the test output is as follows:

00:01 +64 -1: upload upload success [E]
  Expected: 'multipart/form-data'
    Actual: 'application/json'
     Which: is different.
            Expected: multipart/ ...
              Actual: applicatio ...
                      ^
             Differ at offset 0

  package:test_api/src/frontend/expect.dart 153:30              fail
  package:test_api/src/frontend/expect.dart 147:3               _expect
  package:test_api/src/frontend/expect.dart 59:3                expect
  test/multipart_upload_test.dart 161:7                         main.<fn>.<fn>

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Version 2.1.1-beta.5

Additional context

bug ccd released released on @beta

Most helpful comment

Likely related:
https://github.com/dart-lang/http/issues/351
Might be a bug in http 0.12.0+3 and fixed in 0.12.0+4?

Edit: can confirm, the test succeeds with http 0.12.0+4.

All 6 comments

Likely related:
https://github.com/dart-lang/http/issues/351
Might be a bug in http 0.12.0+3 and fixed in 0.12.0+4?

Edit: can confirm, the test succeeds with http 0.12.0+4.

Amazing work @knaeckeKami.

I had a feeling it had to do with the HTTP module, but their changelog just had documentation changes the past couple of releases. Thanks for finding that!!

This issue has been fixed by #530, should be released to beta over the next 24 hours.

:tada: This issue has been resolved in version 3.0.0-beta.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sjmcdowall picture sjmcdowall  路  4Comments

smkhalsa picture smkhalsa  路  3Comments

campanagerald picture campanagerald  路  3Comments

milind-solutelabs picture milind-solutelabs  路  3Comments

micimize picture micimize  路  3Comments