Graphql-flutter: Consider QueryResult.rawFetchResult

Created on 3 Aug 2019 · 3Comments · Source: zino-app/graphql-flutter

Occasionally a user will want a simple way to access protocol-level data, such as headers and cookies (#335) without having to write a custom link. Rather than adding more protocol-level fields to the QueryResult, we should consider adding an "escape hatch" to getting ther raw FetchResult

Source

micimize

Most helpful comment

Hi guys, you can't do something like javascript apollo client do?

const afterwareLink = new ApolloLink((operation, forward) => {
  return forward(operation).map(response => {
    const context = operation.getContext();
    const { response: { headers } } = context;

    if (headers) {
      const refreshToken = headers.get('x-refresh-token');

      if (refreshToken) {
        localStorage.setItem('refreshToken', refreshToken);
      }
    }

    return response;
  });
});

finally you concatenate all

const httpLinkWithMiddleware = afterwareLink.concat(middlewareLink.concat(httpLink));

It would be easier and consistent.

gepd on 12 Sep 2019

👍3

All 3 comments

Hi guys, you can't do something like javascript apollo client do?

const afterwareLink = new ApolloLink((operation, forward) => {
  return forward(operation).map(response => {
    const context = operation.getContext();
    const { response: { headers } } = context;

    if (headers) {
      const refreshToken = headers.get('x-refresh-token');

      if (refreshToken) {
        localStorage.setItem('refreshToken', refreshToken);
      }
    }

    return response;
  });
});

finally you concatenate all

const httpLinkWithMiddleware = afterwareLink.concat(middlewareLink.concat(httpLink));

It would be easier and consistent.

gepd on 12 Sep 2019

👍3

I think QueryResult should not care about rawFetchResult, because it is a concept of the HttpLink. Imho, HttpLink should add any interesting response data to the context so that any user who does not use HttpLink doesn't have QueryResult.rawFetchResult which means nothing in their case.

Another example would be Rest Link where a single operation may become a set of HTTP requests – there the meaning of rawFetchResult is unclear.