Graphiql: Types that lack an "isDeprecated" are included in the deprecation list by default

Created on 26 Jun 2020  路  5Comments  路  Source: graphql/graphiql

As of v1 the isDeprecated field defaults to true if it is not found or defined, which can be seen here. This behavior changed from the v0.x behavior where fields without an isDeprecated field are simply being ignored, which is also what you'd expect.

The issue we are running into is that our graphql server (graphql-dotnet) omits the isDeprecated field for input type fields that are not deprecated, which is now causing the "Show deprecated fields" button to pop up and contain all fields when clicked.

image

Was this change done deliberately, and would you be ok with a PR that reverts this to the v0.x behavior?

Most helpful comment

can I make a PR for this @acao?

All 5 comments

woah good catch! seems this is a regression from the typescript migration
can you open a PR against 1.0.0 branch for that? thank you!

can I make a PR for this @acao?

When will this fix be released?

we have to restructure the repo a bit before we can make the next release to graphiql 1.x, so, sometime in the coming weeks when i get a chance! stay tuned!

this was released last week in 1.0.4, forgot to update here! enjoy!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

songololo picture songololo  路  25Comments

orta picture orta  路  10Comments

divyenduz picture divyenduz  路  16Comments

rherrmann picture rherrmann  路  19Comments

ElijahLynn picture ElijahLynn  路  10Comments