Graphiql: Logger doesn't work anymore

[divyenduz]

From the graphql-language-service-server package (at least, could be shared further).

It used to work before the TS rewrite but now logger emits nothing when connected to say VSCode extension now.

process.stderr.write seems to work though.

[acao]

thanks for reporting, good to know! i'll take a look here today and be sure to have it fixed before the next alpha

[divyenduz]

On the subject of alpha, IDK if it is automated or not, my current workflow is to find the latest alpha via npm info graphql-language-service-server (or some package) and use it, probably worth documenting.

[acao]

you can also do npm i graphql-language-service-server@next

[yoshiakis]

In my local environment, even if I use the version of 2.4.0-alpha.1 of graphql-language-service-service, logger emits a log file under the temp folder. I tested it following the pattern A except step 7. I'll try the step 7 later.

[yoshiakis]

I tried the step 7 using the version of 2.4.0-alpha.1 of graphql-language-service-service and any logs didn't appear in output section under GraphQL Language Server (although the document says it's GraphQL Language Service). However, I also tried it using the version of 2.3.3, which is before the TS rewrite, and the result is the same, which is that any logs didn't appear!

BTW, I used master branch of vscode-graphql to check these.

[acao]

yes i will be getting around to this bug, was trying to identify where the regression originally happened

[yoshiakis]

@divyenduz Do you mean Logger doesn't emit log file in a temp folder or it doesn't emit log in output section under GraphQL Language Service in vscode?

[acao]

I think that it’s also a lack of stdout?

[divyenduz]

@divyenduz Do you mean Logger doesn't emit log file in a temp folder or it doesn't emit log in output section under GraphQL Language Service in vscode?

Yes that is what I meant

[yoshiakis]

@divyenduz Isn't a log file created under ${TMPDIR}/graphql-language-service-logs directory when you follow this set-up A and run and debug vscode-graphql extension?

[divyenduz]

@yoshiakis How do I find the TMPDIR path?

Also, the way it used to work was that the logs appeared in the VSCode Language Client's OutputChannel.

Visually, it should appear here:

As you can see, it still shows this one liner message for cmd + click on a symbol. It used to show all sorts of things like hover on a symbol (the whole LSP request/responses)

[acao]

@divyenduz want to pair on this real quick?

[divyenduz]

This one seems to work because in graphql-language-service-* it is a process.stderr.write

process.stderr.write(`Definition not found for GraphQL type ${name}`);

---

Want to pair on this real quick?

In 10-20 minutes maybe?

[acao]

@divyenduz and I had a session and tried to track down what changed in graphql-languagesrver and client from 3.5.1. My guess is that the language server no longer writes to stderr as it did before, and somewhere in vscode-jsonrpc this changed over major versions. we decided manually writing to stderr in the Logger._log() will fix it for now, but it would be great to know why this regression occurred

[divyenduz]

Related issues:
https://github.com/microsoft/language-server-protocol/issues/184#issuecomment-293530628
https://github.com/microsoft/vscode/issues/20476
https://github.com/microsoft/vscode/issues/20477

[divyenduz]

I think we figured this out! It works now, there are random "undefined" in logs but that is a separate issue 🙌