Graphiql: Errors and tooltips not being shown since 0.10.2

Created on 6 Jul 2017  路  7Comments  路  Source: graphql/graphiql

When using the example set-up the error highlighting stops working. So the red underscore and tooltip with error message aren't shown anymore. Up to v0.10.1 it is working. It's the same issue as #477 which was closed without resolution, and looks similar to #493.

v0.10.1
image

after update to v0.10.2
image

Am I missing a dependency here?

<script src="https://cdnjs.cloudflare.com/ajax/libs/es6-promise/4.1.1/es6-promise.auto.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/fetch/2.0.3/fetch.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.6.1/react.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.6.1/react-dom.min.js"></script>

<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.2/graphiql.min.css" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/graphiql/0.11.2/graphiql.min.js"></script>
bug

Most helpful comment

@oliemansm @joshjcarrier https://github.com/graphql/codemirror-graphql/releases/tag/v0.6.11 takes care of this bug - I'll let greenkeeper update to this revision. Thanks again for reporting!

All 7 comments

Hi @oliemansm - I just ran GraphiQL example app and was able to see all of the features working correctly. You also mention of version 0.10.2, but from your imports I see 0.11.2 - did you put an incorrect version perhaps?

@asiandrummer I've also run in to the syntax underline check, and it repros on a fresh clone, npm run build and npm run dev of master.

graphiql_syntax_check

@joshjcarrier Thanks for verifying!

@asiandrummer I've tried multiple versions, and seen the same behavior starting with 0.10.2 up to the latest 0.11.2. I copied the last try, that's all. Sorry for the confusion.

Thanks guys! I'm taking a look at this right now.

@oliemansm @joshjcarrier https://github.com/graphql/codemirror-graphql/releases/tag/v0.6.11 takes care of this bug - I'll let greenkeeper update to this revision. Thanks again for reporting!

@asiandrummer did greenkeeper pick up this revision? I see yarn.lock still on the old version.

@joshjcarrier. Right you are, looks like it needs an update.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

acao picture acao  路  3Comments

pleunv picture pleunv  路  5Comments

ganemone picture ganemone  路  4Comments

Nishchit14 picture Nishchit14  路  5Comments

samrae7 picture samrae7  路  3Comments