Graphhopper: SpatialRuleLookupArray.lookupRule throws exception

[karussell]

if exact == true and isBorderTile then the empty rule container passes this if clause and we throw an exception for rule.getBorders() here

Is there a return SpatialRule.EMPTY; missing in the mentioned if clause?

[karussell]

(and it looks like we miss a setBorders call in GraphHopperModule.createGraphHopper -> createSpatialRule. I'll have to add an integration test after this both fixed)

[karussell]

The fix seems to work. We still need a test for this and another for the missing setBorders call

[boldtrn]

I am currently looking into this. There seems to be something wrong with the map.geo.json file. Country was renamed to area, but this change is not reflected in GraphHopperModule.java. Also the area descriptions were a bit mixed up. Africa was named South-East Asia and South-East Asia had no area specified. For some reason the EU has drawing properties, whereas the other countries only have the area property. I added my change to the issue_1077 branch, see #1079

I also added an IT for the landmark creation in the GraphHopperModule, which detected above described issue.

[boldtrn]

if exact == true and isBorderTile

I also added a test for this case.

[boldtrn]

(and it looks like we miss a setBorders call in GraphHopperModule.createGraphHopper -> createSpatialRule. I'll have to add an integration test after this both fixed)

How would we write an IT for this? The only option I can see is to import a border region and try to route between the regions.

[karussell]

For some reason the EU has drawing properties, whereas the other countries only have the area property

Maybe this was introduced to geojson.io

I also added an IT for the landmark creation in the GraphHopperModule, which detected above described issue

Hmmh, how did you detect this?

[boldtrn]

Maybe this was introduced to geojson.io

Yes, maybe. It is not an issue, It just looks a bit inconsistent.

Hmmh, how did you detect this?

See the failing test. It was fixed with the next commit. Essentially it was not possible to calculate landmarks. This could also mean that we are not using the cut continents right now in the landmark creation. I don't think that cutting the continents would have worked with the current master.