Graphback: Change all test file suffixes to be `.test.ts`

Created on 1 Oct 2020  路  8Comments  路  Source: aerogear/graphback

Problem

All test files have the following naming convention:

/tests/*Test.ts

Examples:

  • KnexDbDataProviderTest.ts
  • CRUDServiceTest.ts
  • createInMemoryFilterPredicateTest.ts

It is difficult to differentiate a test file from a regular module file at a glance, for example:

createInMemoryFilterPredicateTest.ts compared to createInMemoryFilterPredicate.ts.

Solution

All test files should get renamed with a .test.ts suffix instead. This is probably the most common naming pattern used in JavaScript/TypeScript.

New naming pattern: /tests/*.test.ts

Examples:

  • KnexDbDataProvider.test.ts
  • CRUDService.test.ts
  • createInMemoryFilterPredicate.test.ts
good first issue tests Hacktoberfest up for grabs

All 8 comments

Automatically generated comment to notify maintainers
/cc @machi1990, @wtrocki

may i do it

please 馃檹

Hi @codetravellearn - yes you can do this one. Thank you so much for offering to help! I will assign you for now, but if your PR does not progress I will eventually unassign you, so keep active and let us know if you are having issues.

First thing you should do is go to the CONTRIBUTING.md file to set up your development environment.

Wanna work

@codetravellearn has been assigned this task @Codedude1. Can you please be more through in your comments and offer more than "Wanna work" for us to consider assigning you. Thanks.

This one is still open, right?

Mind if I pick it up?

Hi @Odin94!

There is currently a PR in progress but it has been pretty inactive for a couple of days. Of course, feel free to take it :+1: Thanks.

Was this page helpful?
0 / 5 - 0 ratings