Gollum: upload filename inconsistency between client/server side

[andreabedini]

Hi there,

thanks for the awesome work with gollum. I found this little bug, when I drag&drop an image the client side inserts a tag like the following in the text (here I had launched gollum with --allow-uploads page)

[[Home/Screen Shot 2015-03-05 at 2.53.23 pm.png]]

but the uploaded file is rather Home/Screen-Shot-2015-03-05-at-2.53.23-pm.png

so the user ends up with a broken link and possibly a 'lost' file.

[andreabedini]

I notice now that also the commit log is wrong about the filename

Uploaded file to Home/Screen Shot 2015-03-05 at 2.53.23 pm.png

[dometto]

Thanks for reporting this! I won't have time to look at it this month, but a bugfix is more than welcome. The relevant code is here.

[andreabedini]

I'm having a look and I found another (related) problem, uploading a duplicated file returns status code 200 (see https://github.com/gollum/gollum/blob/master/lib/gollum/app.rb#L209-L212) and the client side ignores the problem. It seems the backend sanitize the name in https://github.com/gollum/gollum/blob/master/lib/gollum/app.rb#L544 but currently there's no way to notify the client side of the new name.

[dometto]

I suppose we need to either mimic the logic of file name sanitization in JS, or else generate the file name through an AJAX call. Thoughts?

[andreabedini]

I'd say file name sanitization entirely in JS, backend only accepts sanitized name (e.g. via a simple regexp) or refuses the upload.
my 2c

[andreabedini]

@dometto sorry I had _zero_ time to work on this.

[amccaugh]

I've found the same issue here -- any word on the progress? I'm hoping to use gollum for scientific/data recordkeeping, so filename inconsistencies on uplaod are a dealbreaker on my end. I'm really impressed with it otherwise though!

[dometto]

Sorry @amccaugh , still hoping someone will have time to come up with a fix. Note that you can always use git to add new files to the repo, so if you would have push access to the wiki you can use git push to add files in a safe manner.

[bartkamphorst]

@andreabedini Just checking in. Any prospect of a PR for this issue?

[andreabedini]

@bartkamphorst nope sorry

[bartkamphorst]

No worries, thanks for letting us know!

[JSteunou]

Status on this issue? I'm starting with gollum and have this bug too. If this from gollum-lib or gollum?

[dometto]

The fix to this issue will come for free in the upcoming 5.0 release (might be a while though). We've stopped sanitizing filenames in this way (read about it here) from v5 onward, so the discrepancy is no longer there.

I'll close this issue in the mean time to give us a better overview of things we need to address in the upcoming release.