Godot version:
v3.2.beta.custom_build.14e52f7ae
OS/device including version:
Ubuntu
Issue description:
[ 96%] Linking Shared Library ==> bin/libgodot.android.opt.armv8.so
modules/libmodules.android.opt.armv8.a(opus_decoder.android.opt.armv8.o): In function `opus_decoder_init':
opus_decoder.c:(.text.opus_decoder_init+0x180): undefined reference to `opus_select_arch'
modules/libmodules.android.opt.armv8.a(celt_decoder.android.opt.armv8.o): In function `celt_decoder_init':
celt_decoder.c:(.text.celt_decoder_init+0x9c): undefined reference to `opus_select_arch'
modules/libmodules.android.opt.armv8.a(pitch.android.opt.armv8.o): In function `pitch_search':
pitch.c:(.text.pitch_search+0x4a8): undefined reference to `CELT_PITCH_XCORR_IMPL'
pitch.c:(.text.pitch_search+0x4ac): undefined reference to `CELT_PITCH_XCORR_IMPL'
modules/libmodules.android.opt.armv8.a(celt_lpc.android.opt.armv8.o): In function `_celt_autocorr':
celt_lpc.c:(.text._celt_autocorr+0x258): undefined reference to `CELT_PITCH_XCORR_IMPL'
celt_lpc.c:(.text._celt_autocorr+0x25c): undefined reference to `CELT_PITCH_XCORR_IMPL'
modules/libmodules.android.opt.armv8.a(init_decoder.android.opt.armv8.o): In function `silk_init_decoder':
init_decoder.c:(.text.silk_init_decoder+0x24): undefined reference to `opus_select_arch'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
scons: *** [bin/libgodot.android.opt.armv8.so] Error 1
scons: building terminated because of errors.
Steps to reproduce:
scons platform=android target=release android_arch=arm64v8
related? https://github.com/xiph/opus/issues/140
revert https://github.com/godotengine/godot/commit/ba4c808721592a8558686b518d12f36e0fe60957 solves the issue
I can confirm this on commit https://github.com/godotengine/godot/commit/fea3890e1e994257a27cbf7480d8d4cdb037cfa6.
I can confirm this on commit 98caeb635.
@akien-mga Any opposition to reverting PR #33311 for now?
I'd prefer fixing the build issue properly, which shouldn't be hard. I'll work on it tomorrow morning.
Edit: After a quick look, fixing this doesn't seem so easy. It's probably possible to find a relatively clean fix to make things build, but I have doubts on whether either the previous or the new config.h is correct. Best leave that for later and go back to what was working.
Most helpful comment
I'd prefer fixing the build issue properly, which shouldn't be hard. I'll work on it tomorrow morning.
Edit: After a quick look, fixing this doesn't seem so easy. It's probably possible to find a relatively clean fix to make things build, but I have doubts on whether either the previous or the new
config.his correct. Best leave that for later and go back to what was working.