Godot: SurfaceTool::add_normal() doesn't normalize, while ImmediateGeometry::set_normal() does
Godot version:
3.1 Alpha 5
Issue description:
Used both SurfaceTool and ImmediateGeometry to render the same geometry. But forgot to normalize my normals. Resulting renders differ from each other in brightness, because only ImmediateGeometry normalized my given normals.
More information:
https://www.reddit.com/r/godot/comments/ad0eqe/immediategeometry_renders_differently_from_a/
Jvanmourik
All 2 comments
Might be by design but inconsistencies like this one could cause a lot of confusion to unknowing users.
Jvanmourik
on 6 Jan 2019
In my opinion neither should automatically normalize or modify any passed values (if that happens now). In customized shaders people often use normals and texture uv's to pass custom data and modifying it in any way could break things and prevent these kinds of often very useful tricks.
bitsawer
on 7 Jan 2019
Related issues
ndee85
路
3Comments
RebelliousX
路
3Comments
kirilledelman
路
3Comments
timoschwarzer
路
3Comments
blurymind
路
3Comments
Most helpful comment
In my opinion neither should automatically normalize or modify any passed values (if that happens now). In customized shaders people often use normals and texture uv's to pass custom data and modifying it in any way could break things and prevent these kinds of often very useful tricks.