Godot: Particle sprite sheet animation no longer working correctly

Created on 20 Oct 2018  路  4Comments  路  Source: godotengine/godot

Godot version:
Master, built today

OS/device including version:
Windows 7 64bit

Issue description:
I built a new version of Godot this morning as I hadn't updated for a while and I noticed the particle effects in my game now looked weird. Seems like something has happened to the animation code and the frames are getting chopped off:

image

Steps to reproduce:
Open the attached project and you should see the problem

Minimal reproduction project:
particle_bug.zip

bug rendering

Most helpful comment

Ran a bisect:

git bisect start
# bad: [a36a99b846ddc6bb499dca9a7dcdecaada8d08b5] Merge pull request #23229 from CakHuri/fix-treshold
git bisect bad a36a99b846ddc6bb499dca9a7dcdecaada8d08b5
# good: [c432ce4ee15fc396b2bccbbe2661b5bd34b9bee1] Merge pull request #22400 from Chaosus/viewport_color
git bisect good c432ce4ee15fc396b2bccbbe2661b5bd34b9bee1
# bad: [05fe3121806b66f42e035968560b0fc881c1048d] Merge pull request #22690 from jfmichaud31/fix_gles2_shader
git bisect bad 05fe3121806b66f42e035968560b0fc881c1048d
# bad: [9258d7b5d0942f1cad3f9b0ba41a3c916ea6b89e] Fix warnings about uninitialized vars [-Wsometimes-uninitialized]
git bisect bad 9258d7b5d0942f1cad3f9b0ba41a3c916ea6b89e
# good: [c3bb4edb79db9377b803e88d6385e6842ba0871f] Merge pull request #22508 from groud/add_thumnail_filelist
git bisect good c3bb4edb79db9377b803e88d6385e6842ba0871f
# bad: [3ee657e7a7ffdcdb1fd46e095fef97622b99e909] Merge pull request #22557 from mhilbrunner/docs-transfermodes
git bisect bad 3ee657e7a7ffdcdb1fd46e095fef97622b99e909
# bad: [c6f09fb97b48903f8d9d8d3b030b3b03d0a87e19] Merge pull request #22532 from moiman100/fix-windows-build
git bisect bad c6f09fb97b48903f8d9d8d3b030b3b03d0a87e19
# good: [f2ed26d71e20b92dbf21693eeea36ccfcc50ced6] Reflection probe support in GLES2 back-end.
git bisect good f2ed26d71e20b92dbf21693eeea36ccfcc50ced6
# good: [da296ce30f16eb9fd4835cbd3911856d852eb5b2] Fixed casting result in float.xml
git bisect good da296ce30f16eb9fd4835cbd3911856d852eb5b2
# good: [8d31aba24e2572bb8d5fe91a486e09b1fa1cc0b6] Fix inconsistent use of tabs and spaces in indentation
git bisect good 8d31aba24e2572bb8d5fe91a486e09b1fa1cc0b6
# bad: [f1c2c3038cc3fa57b266262615cb463760ac15ab] Merge pull request #22527 from FlamyAT/patch-1
git bisect bad f1c2c3038cc3fa57b266262615cb463760ac15ab
# bad: [0de8309b2c38306a2c05f8f239fa423bc1b7899b] Many fixes to GLES2 renderer, fixed compilation issues in GLES3 shaders.
git bisect bad 0de8309b2c38306a2c05f8f239fa423bc1b7899b
# first bad commit: [0de8309b2c38306a2c05f8f239fa423bc1b7899b] Many fixes to GLES2 renderer, fixed compilation issues in GLES3 shaders.

So, seems like 0de8309b2c38306a2c05f8f239fa423bc1b7899b is the culprit here.
Specifically, a floor was missed on this line: https://github.com/godotengine/godot/commit/0de8309b2c38306a2c05f8f239fa423bc1b7899b#diff-b35d24e9665a8bf20f2f655e1ac19e39R617

PR incoming.

Edit: And, BTW, kudos for the concise and useful reproduction project.

All 4 comments

Do you know what date/commit your previous working build was built from?

My last merge with master was on Aug 28th with I believe this commit 6671096dd7a442b250a8d07a175db99ba02e6d5a

It's working fine, in commit c432ce4. This is from 24th Sept.
Has problems in the latest builds too.

Ran a bisect:

git bisect start
# bad: [a36a99b846ddc6bb499dca9a7dcdecaada8d08b5] Merge pull request #23229 from CakHuri/fix-treshold
git bisect bad a36a99b846ddc6bb499dca9a7dcdecaada8d08b5
# good: [c432ce4ee15fc396b2bccbbe2661b5bd34b9bee1] Merge pull request #22400 from Chaosus/viewport_color
git bisect good c432ce4ee15fc396b2bccbbe2661b5bd34b9bee1
# bad: [05fe3121806b66f42e035968560b0fc881c1048d] Merge pull request #22690 from jfmichaud31/fix_gles2_shader
git bisect bad 05fe3121806b66f42e035968560b0fc881c1048d
# bad: [9258d7b5d0942f1cad3f9b0ba41a3c916ea6b89e] Fix warnings about uninitialized vars [-Wsometimes-uninitialized]
git bisect bad 9258d7b5d0942f1cad3f9b0ba41a3c916ea6b89e
# good: [c3bb4edb79db9377b803e88d6385e6842ba0871f] Merge pull request #22508 from groud/add_thumnail_filelist
git bisect good c3bb4edb79db9377b803e88d6385e6842ba0871f
# bad: [3ee657e7a7ffdcdb1fd46e095fef97622b99e909] Merge pull request #22557 from mhilbrunner/docs-transfermodes
git bisect bad 3ee657e7a7ffdcdb1fd46e095fef97622b99e909
# bad: [c6f09fb97b48903f8d9d8d3b030b3b03d0a87e19] Merge pull request #22532 from moiman100/fix-windows-build
git bisect bad c6f09fb97b48903f8d9d8d3b030b3b03d0a87e19
# good: [f2ed26d71e20b92dbf21693eeea36ccfcc50ced6] Reflection probe support in GLES2 back-end.
git bisect good f2ed26d71e20b92dbf21693eeea36ccfcc50ced6
# good: [da296ce30f16eb9fd4835cbd3911856d852eb5b2] Fixed casting result in float.xml
git bisect good da296ce30f16eb9fd4835cbd3911856d852eb5b2
# good: [8d31aba24e2572bb8d5fe91a486e09b1fa1cc0b6] Fix inconsistent use of tabs and spaces in indentation
git bisect good 8d31aba24e2572bb8d5fe91a486e09b1fa1cc0b6
# bad: [f1c2c3038cc3fa57b266262615cb463760ac15ab] Merge pull request #22527 from FlamyAT/patch-1
git bisect bad f1c2c3038cc3fa57b266262615cb463760ac15ab
# bad: [0de8309b2c38306a2c05f8f239fa423bc1b7899b] Many fixes to GLES2 renderer, fixed compilation issues in GLES3 shaders.
git bisect bad 0de8309b2c38306a2c05f8f239fa423bc1b7899b
# first bad commit: [0de8309b2c38306a2c05f8f239fa423bc1b7899b] Many fixes to GLES2 renderer, fixed compilation issues in GLES3 shaders.

So, seems like 0de8309b2c38306a2c05f8f239fa423bc1b7899b is the culprit here.
Specifically, a floor was missed on this line: https://github.com/godotengine/godot/commit/0de8309b2c38306a2c05f8f239fa423bc1b7899b#diff-b35d24e9665a8bf20f2f655e1ac19e39R617

PR incoming.

Edit: And, BTW, kudos for the concise and useful reproduction project.

Was this page helpful?
0 / 5 - 0 ratings