Godot: The find/search selection highlight for the built in documentation is very hard to see.
Alpha 3.1 6cbdeedf57c7383827416da19b6026e3721f2812
Small enhancement request. When doing a search/find within editor documentation, the selection highlight is very difficult to find. Most the time I wonder if it was deselected. I'm not sure what to recommend as far as a highlight color.
Take a look at this screenshot and see how long it takes you to find the selection.
avencherus
All 26 comments
This happened to me too, I agree the highlight color is too subtle.
groud
on 30 Sep 2018
I give up. I rather find Wally.
neikeq
on 30 Sep 2018
@neikeq Haha, here he is! XD
avencherus
on 30 Sep 2018
:+1:
:-1:
Something else?
:heart:
AlexHolly
on 1 Oct 2018
I think it would make sense to reuse the text editor's selection color for this.
Calinou
on 1 Oct 2018
I think there was an issue about this already, but I can't find it.
vnen
on 1 Oct 2018
AlexHolly
on 1 Oct 2018
@AlexHolly Would say green is certainly clearer of the two, but maybe what calinou suggested works out just fine. I'm fairly unqualified to vote on UI color choices though, so take it with a grain of salt. X)
avencherus
on 1 Oct 2018
The TextEditor color looks kind of the same and adding a Border like the CodeEditor has would be a bit work.
AlexHolly
on 1 Oct 2018
I'd suggest to choose a color that satisfies this 'algorithm':
http://www.w3.org/TR/AERT#color-contrast
It checks if two colors have enough contrast including for color-blinded people.
rodolforg
on 2 Oct 2018
@rodolforg Interesting resource, and it also had an amusing typo. XD
The rage for color brightness difference is 125.
avencherus
on 2 Oct 2018
I agree with @rodolforg, the color should be WCAG 2.0 compliant.
btn0s
on 3 Oct 2018
WCAG 2.0 is brilliant in general, for a default theme green or yellow should be good to go.
Zireael07
on 3 Oct 2018
Planning on giving it a go, so should I make it green with white text?
swarnimarun
on 3 Oct 2018
252C3B is the color of the background, which passes on all WCAG thresholds with #00FF79 as the green.
I'd do text #252C3B
with background #00FF79
btn0s
on 3 Oct 2018
I'd do text #252C3B
with background #00FF79
@btn0s This?
avencherus
on 3 Oct 2018
No need to reinvent the wheel, as @Calinou said:
I think it would make sense to reuse the text editor's selection color for this.
If you then want to review text editor default colors to match UX best practices, that's fine, but the fix for this issue should just be to reuse the existing selection color.
akien-mga
on 4 Oct 2018
While we are on it, is there a reason the built in documentation does not have the same color coding as the online documentation? I never use the build in documentation, because I find the online version much easier to differentiate.
metaphoricalsasquash
on 6 Oct 2018
Does #21195 resolve this or is it still available for hacktoberfest?
samgreen
on 6 Oct 2018
While we are on it, is there a reason the built in documentation does not have the same color coding as the online documentation?
The built-in documentation is themed to match the Godot editor, which means it uses a dark theme by default.
Calinou
on 6 Oct 2018
The built-in documentation is themed to match the Godot editor, which means it uses a dark theme by default.
The dark two tone coloring may be pretty, not the best choice to learn, imho. Because both online documentation as well as GDscript inside the editor are using other color coding. Because it is multi colored, it's a lot easier to grasp. Ideally, I wish all three had the same color coding.
metaphoricalsasquash
on 6 Oct 2018
Bump. Is this resolved with #21195? (so, 3.1)
bojidar-bg
on 13 Dec 2018
Not 100% sure but this is what I see in alpha 3:
I haven't changed any settings in alpha 3 itself and IIRC settings should be version-independent, but definitely not the greenish color that it should be after #21195.
Zireael07
on 13 Dec 2018
That's the expected color from #21195, 40808080 is ARGB, so it's gray with low opacity.
I agree that it's still not visible enough though. The background rect should likely be made a bit taller too to be easier to spot.
akien-mga
on 17 Dec 2018
Ah, I put 40808080 in a html picker so it outputted a nice contrasting green, probably the picker interpreted it as RGBA :)
Zireael07
on 17 Dec 2018
apparently the colors yellow and orange don't exist, lol..
girng
on 28 Mar 2019
Related issues
Zylann
路
3Comments
ndee85
路
3Comments
n-pigeon
路
3Comments
kirilledelman
路
3Comments
mooseyfaith
路
3Comments
Most helpful comment
I give up. I rather find Wally.