Godot: Make "Syntax Highlighter" a radio menu

Created on 11 May 2018  Â·  9Comments  Â·  Source: godotengine/godot

Godot version:
1ec2fa4

Issue description:
I don't exactly know what's its purpose, but while it acts like a radio menu, it's not set as one:
screenshot1

enhancement junior job editor usability

Most helpful comment

There are many files which have a custom file extension even though they use are a known format. Things like csproj/*proj (xml), ini-like formats. It's good to give the user a choice on this.

All 9 comments

CC @Paulb23

Please remove this entry (it is an useless feature, the syntax should be already
known to the editor). At least move it somewhere else (e.g. File menu, Editor configuration, …)
Thanks.

It's not useless, but I agree that it should be a sub-menu (probably in Edit?).

The beloved colour variations should be handled in the syntax theme, the language syntax parser should be automatically determined by the currently edited language. Manually switching the editor syntax highlighter sounds useless, error-prone, not sane, … but I'm for sure missing something ;)

Yes, a sub-menu in Edit would be better.

Most editors allow manually specifying the language, while still detecting it automatically. It would be even more useful if we ever add support to the editor for editing non-script files.
IMO, it should be moved to the status bar at the bottom, next to the line and column labels. Language, encoding and line endings selectors are commonly placed there.

I don't remember the last time I needed to disable the autodetection in a general purpose editor and they must cope with an endless amount of possibilities.

Godot generally have to know how to handle any text file anyway, so I think the internal editor doesn't need such overrides.

There are many files which have a custom file extension even though they use are a known format. Things like csproj/*proj (xml), ini-like formats. It's good to give the user a choice on this.

Actually I like the current alpaca design pattern to not swallow unknown vegetables in the first place ;)

The engine or plug-in can associate all known used files with a format or meaning (e.g with a content header/ID independent of the file extension). I think, it's a better to give the alpaca the choice and don't bother the editor-user with an, at a some point, giant syntax-options-tree. The engine or plug-in unrelated files are out of scope of the internal editor and belong to an another IDE.

alpaca

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SleepProgger picture SleepProgger  Â·  3Comments

rgrams picture rgrams  Â·  3Comments

RebelliousX picture RebelliousX  Â·  3Comments

testman42 picture testman42  Â·  3Comments

EdwardAngeles picture EdwardAngeles  Â·  3Comments