Godot: Godot 2.1.4 crash on some Android devices (_ZN17AudioDriverOpenSL9set_pauseEb)

Created on 1 Apr 2018 · 19Comments · Source: godotengine/godot

Hi guys,
I released my game on Android using Godot 2.1.4 and I'm getting a lot of crash from different device about this issue:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)

pid: 0, tid: 0 >>> it.megasoft78.fallingword <<<

backtrace:
#00 pc 0000000000033f20 /data/app/it.megasoft78.fallingword-1/lib/arm/libgodot_android.so (_ZN17AudioDriverOpenSL9set_pauseEb+24)
#01 pc 000000000003e2dc /data/app/it.megasoft78.fallingword-1/lib/arm/libgodot_android.so (Java_org_godotengine_godot_GodotLib_focusin+64)
#02 pc 000000000062cb7d /data/app/it.megasoft78.fallingword-1/oat/arm/base.odex

Here's the list of some devices:

Samsung Galaxy Tab A 10.1 (gtaxllte), 2048MB RAM, Android 7.0
Samsung Galaxy S6 (zeroflte), 3072MB RAM, Android 7.0
ZTE Blade X Max (stollen), 2048MB RAM, Android 7.1
Hisense F23 (HS6737MT), 1024MB RAM, Android 7.0
Samsung Galaxy A5(2016) (a5xelte), 2048MB RAM, Android 7.0
Samsung Galaxy S7 (herolte), 4096MB RAM, Android 7.0
Samsung Galaxy S6 Edge (zerolte), 3072MB RAM, Android 7.0
Samsung Galaxy J7 Max (j7maxlte), 4096MB RAM, Android 7.0
Samsung Galaxy J5(2016) (j5xnlte), 2048MB RAM, Android 7.1
Samsung Galaxy A3(2017) (a3y17lte), 2048MB RAM, Android 7.0

I tried with all the devices I have but I'm not able to reproduce it.

Could you please help me?

bug android porting

Source

megasoft78

All 19 comments

looks like there's something wrong here.

https://github.com/godotengine/godot/blob/2.1/platform/android/audio_driver_opensl.cpp#L376-L387

volzhs on 1 Apr 2018

maybe combination of...
connecting/disconnecting of earphone jack and...
go back and front of game?

volzhs on 1 Apr 2018

@volzhs What do you mean for go back and front game?
I did try with connecting/disconnecting the earnphone on my device but it doesn't crash. I also tried to do it when sound was playing but no crash.
I don't think is that anyway because it's happening too often. I don't think there are so many people playing with earphone jack all the time.
Any other ideas?

megasoft78 on 1 Apr 2018

This seems to be the calling method:

void OS_Android::main_loop_focusin() {

    if (main_loop)
        main_loop->notification(MainLoop::NOTIFICATION_WM_FOCUS_IN);
    audio_driver_android.set_pause(false);
}

https://github.com/godotengine/godot/blob/b3f43496a503096e52d6e3f7522a24b251e7bc98/platform/android/os_android.cpp

megasoft78 on 1 Apr 2018

It's called onResume by Android:
https://github.com/godotengine/godot/blob/bbd8f2c1b42fbf800ae4703c3c68c4faef114331/platform/android/java/src/org/godotengine/godot/Godot.java

@Override
    protected void onResume() {
// Other code...
        mView.onResume();
        mView.queueEvent(new Runnable() {
            @Override
            public void run() {
                GodotLib.focusin();
            }
        });
// Other code...

megasoft78 on 1 Apr 2018

I don't have a clue either, but I guessed the condition from the code.

normal run > connect earphone > pressing home button to game goes to background > anyway to come game back on foreground
normal run > connect earphone > pressing home button to game goes to background > unplug earphone > game foreground
normal run with earphone connected > etc....

volzhs on 1 Apr 2018

I tried all the possible combinations. It's not that or at least it doesn't happen on my devices. :(

megasoft78 on 1 Apr 2018

sad to hear that... I wish we could have a reproducing steps...

volzhs on 1 Apr 2018

Is it possible that the instance of playItf is null or not initialized because it was paused?

(*playItf)->SetPlayState(playItf, SL_PLAYSTATE_PAUSED);

megasoft78 on 1 Apr 2018

👍1

I'm suspicious about that but I can't confirm until reproducing it.

volzhs on 1 Apr 2018

active is supposed to be true if playItf is initialized. Meaning if we are calling SetPlayState, then playItf can't be null. Right now I'm reading this OpenSL documentation and trying to figure out what is happening here.

xsellier on 4 Apr 2018

Hi,
I'm not an expert but at page 560 of that document is saying
/* Pause the music - only do so if it is playing */
Maybe it's that?

megasoft78 on 4 Apr 2018

👍1

@megasoft78 Awesome, I was on the same _possible_ solution for this problem:

https://stackoverflow.com/questions/9871516/opensl-es-crashes-randomly-on-samsung-galaxy-sii-gt-i9100/api.stackexchange.com

xsellier on 4 Apr 2018

As I said I'm not an expert on this things.
Are you a Godot developer? Do you think checking if it's playing will solve the problem?
Do I need to check if playItf is null as well?
Could you post the code for that?

megasoft78 on 4 Apr 2018

@megasoft78 I'm a godot contributor, not a core maintainer. I'm not an expert, but I will compile it, and test it. I will test it on:

Nokia 6 Android 8.0
Nokia 6 Android 8.1
Samsung S4 Android 5.1
Samsung S4 Android 4.4

Once done, I will remove the WIP tag on the merge request.

Feel free to perform more tests on your side :100:

EDIT
I don't think we need to check if playItf is null because it is a global reference, so to be deleted we have to stop the main loop, and we would not have an issue on focusin.

xsellier on 4 Apr 2018

Hi @xsellier,
Thank you very much.
Unfortunatelly I'm not able to reproduce it on my devices.
I got this error from Google Play Console.
Anyway when you'll have the changes I'll try to compile Godot with your changes and publish on the market. I'm sure if it doesn't work I'll see it in few days. :)

megasoft78 on 4 Apr 2018

👍1

I've tested it on my phones and it works properly.