Godot: It's not clear who wins in the depth prepass project settings

Created on 8 Jan 2018  路  6Comments  路  Source: godotengine/godot

Godot version:

37ca542d2bfd9aac296e82e30a76117090dea08e

Issue description:
The disable check-box isn't needed:

autsch

bug junior job rendering

Most helpful comment

grafik

All 6 comments

rendering/quality/depth_prepass/disable should be removed, it's not used.

The other two are defined here: https://github.com/godotengine/godot/blob/34c988cfa92f19c232b65990704816ba1c7d2622/servers/visual_server.cpp#L1958-L1959

And used here, where you can see that disable is defined but unused (and should thus be removed there): https://github.com/godotengine/godot/blob/bfeaf27a3e41cd60ec7be4c1d88a3edd2c2a6d87/drivers/gles3/rasterizer_storage_gles3.cpp#L7254-L7261

GLOBAL_DEF("rendering/quality/depth_prepass/disable_for_vendors", "PowerVR,Mali,Adreno");

While fixing this issue, I'd propose to change the String to "PowerVR, Mali, Adreno", to make it clear that it's comma-separated but that it's OK to use spaces (they're stripped eventually). That's just cosmetic though :)

Edit: Or not, maybe it's fine as is.

If it's a junior job I will give a try tonight

It's literally a "remove the line @akien-mga said should be removed" job :P

fixed by #15500

grafik

Was this page helpful?
0 / 5 - 0 ratings