Godot: "(Unsaved changes will be lost)" is too frightening

Created on 20 May 2016  路  8Comments  路  Source: godotengine/godot

Operating system or device - Godot version:
Any version of Godot since at least 1.0betaxx on any platform

Issue description (what happened, and what was expected):
When you quit the editor to project list, there is this nightmarish dialog box asking you to confirm :

Please Confirm...x
Open Project Manager ?
(Unsaved changes will be lost)
[QUIT (and do nightmares)] [Cancel (if you're too afraid to quit)]

It would be cool if instead of terrorizing us, the editor was kind enough to tell us what file are not save when files are not saved.

On the other hand, when you just Quit, there is no such warning.

Steps to reproduce:
Quit to the project list.

Link to minimal example project (optional but very welcome):

enhancement junior job editor usability

Most helpful comment

@balloonpopper Sounds cool, though it might be better named as:

  1. Save changes (the changes part can be dropped)
  2. Discard changes
  3. Cancel
    Since, having two "Yes" buttons is terrible in general.

All 8 comments

It looks like https://github.com/godotengine/godot/blob/master/tools/editor/editor_node.cpp#L2686 doesn't have any check if there are not saved files/scenes:

case RUN_PROJECT_MANAGER: {

    if (!p_confirmed) {
        confirmation->get_ok()->set_text(TTR("Yes"));
        confirmation->set_text("Open Project Manager? \n(Unsaved changes will be lost)");
        confirmation->popup_centered_minsize();
        break;
    }

(or maybe it's set in that p_confirmed)

The Scene close function does it this way:

if (!p_confirmed && unsaved_cache) {
    confirmation->get_ok()->set_text(TTR("Yes"));
    //confirmation->get_cancel()->show();
    confirmation->set_text(TTR("Close scene? (Unsaved changes will be lost)"));
    confirmation->popup_centered_minsize();
    break;
}

_remove_edited_scene();

Ideally I'd like to see the exit dialog aware of whether there's outstanding changes, but if this isn't feasible, how about a 3 option window with
Open project manager?
1) Yes (Saves all scenes)
2) Yes (Lose any changes)
3) Cancel

@balloonpopper Sounds cool, though it might be better named as:

  1. Save changes (the changes part can be dropped)
  2. Discard changes
  3. Cancel
    Since, having two "Yes" buttons is terrible in general.

Fixed by #9304?

I had this issue too where my system failed to update because Godot blocked a shutdown because it was open with no changes to be saved at all.

It should just allow the OS to close it if there are no changes.

@b-hayes This issue has been considered fixed for the better part of the last 3 years. I would suggest opening a new issue describing the problem you are having instead of bumping this one :smiley:

@b-hayes #32321 will address this if it's merged. You can already disable the quit confirmation in the Editor Settings.

Was this page helpful?
0 / 5 - 0 ratings