Go-github: Support new "Delete Reactions" endpoints

Created on 27 Feb 2020  路  10Comments  路  Source: google/go-github

GitHub Developer API announcement:
https://developer.github.com/changes/2020-02-26-new-delete-reactions-endpoints/

These new endpoints need to be supported:

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

enhancement good first issue

Most helpful comment

@gmlewis I could take it over

All 10 comments

@gmlewis I could take it over

Thank you, @wesleimp! It is yours.

I neglected to mention that the existing "delete reactions" endpoint also needs to be deleted (assuming we implemented it... I'll have to check later).

I neglected to mention that the existing "delete reactions" endpoint also needs to be deleted (assuming we implemented it... I'll have to check later).

@gmlewis I'll delete the endpoint DeleteReactions when all these endpoints mentioned above are be supported. What do you think?

We typically add new endpoints and delete deprecated endpoints in the same PR so that the single issue (pointing to a blog post) can be fully closed and so that it can be more easily found.
But I'm actually fine to split the single issue up into ~two~ multiple PRs if you would prefer.

We typically add new endpoints and delete deprecated endpoints in the same PR so that the single issue (pointing to a blog post) can be fully closed and so that it can be more easily found.
But I'm actually fine to split the single issue up into ~two~ multiple PRs if you would prefer.

@gmlewis I prefer to split the issue in multiple PRs to make the review easier, but after the #1445 meged, I can close this issue in a single one. No problems to me

I would like to take the second bullet point.

Thank you, @ayzu, but @wesleimp already signed up for the full issue.

Oh, my bad:)

Thank you, @ayzu, but @wesleimp already signed up for the full issue.

No problem, @ayzu ! It's always better to have more volunteers than not enough! 馃榿

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gmlewis picture gmlewis  路  3Comments

zulhfreelancer picture zulhfreelancer  路  3Comments

adrienzieba picture adrienzieba  路  3Comments

csandanov picture csandanov  路  3Comments

gmlewis picture gmlewis  路  3Comments