Go-github: Support GitHub Actions API

Created on 28 Jan 2020  路  22Comments  路  Source: google/go-github

Most helpful comment

@gmlewis @bramwelt I tested the API manually and despite what documentations suggests, it indeed returns 204 No Content on both create and update.

I've reached out to GitHub support and updated the conversion with them in #1402, https://github.com/google/go-github/pull/1402#issuecomment-592332173

I'll post their response there and will mention you so you both are up to date.

All 22 comments

Usually there is a blog announcement, and apparently there wasn't for this. Thanks, @joshuabezaleel.

This would be a great PR for any new contributor to this repo or any Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

actions_secrets.go - assigned to @martinssipenko.

In order to fully close this issue, we need PRs that will address all the following sections of the announcement:

  • [x] actions_artifacts.go docs (#1414 - completed by @atorr)
  • [x] actions_secrets.go docs (#1402 - completed by @martinssipenko)
  • [x] actions_runners.go docs (#1446 - completed by @nightlark)
  • [x] actions_workflows.go docs (#1411 - completed by @joshuabezaleel)
  • [x] actions_workflow_jobs.go docs (#1421 - completed by @joshuabezaleel)
  • [x] actions_workflow_runs.go docs (#1449 - completed by @ayzu)

Since this is a lot of work, let's open this up to multiple developers... please volunteer for one section in the list above, and piggy-back upon the excellent work that @martinssipenko has started in #1402.

Thank you!

Haven't got a chance to look at it but I want to take a shot. Perhaps the actions_workflows one.

May I contribute to the actions_artifacts section?

Since my incoming PR will be dependent to @martinssipenko 's PR that contains ActionsService on actions.go, should I wait for that particular PR to be merged or I can raise a PR with ActionsService written in my code as if it's already merged?

cc: @gmlewis

@joshuabezaleel you can branch off of my branch.

Hey volunteers, I am super-pleased with the way this Issue is coming together... starting off with the excellent groundwork from @martinssipenko followed by another great PR from @joshuabezaleel!

Let's keep up this excellent progress going by having more people volunteer to complete the unchecked and unassigned items above.

Please remember to check out our CONTRIBUTING.md guide to get started... and thank you in advance for your contributions!

Interested in getting the actions_runners working.

Interested in getting the actions_runners working.

@nightlark - does that mean you are volunteering to implement action_runners.go or you are just interested that _someone_ gets this working?
I would hate to assign this issue to you if it is just the latter. :smile:

If it is the former, thank you very much, and I will put your name as its owner.

I would love to work more on this if it's permissible and no one is taking it. But if we should distribute the contribution, that would be lovely to do so :slightly_smiling_face: cc: @gmlewis

Hi @joshuabezaleel - that's fantastic... thank you!

I think we give people ample opportunity to sign up for working on this repo, so feel free to volunteer for more endpoints (as we await LGTMs). (I think we should probably give @nightlark another day to respond to my question... so feel free to pick a different one while we are waiting for a response. :smile:)

@gmlewis I鈥檒l take on implementing support for the runners api.

@gmlewis I鈥檒l take on implementing support for the runners api.

Thank you, @nightlark! I've assigned actions_runners.go to you above.

Hi awesome volunteers, we still have one task above that needs an implementation.

Now that pioneers like @martinssipenko, @joshuabezaleel, and @atorr have forged ahead with their portions, there are excellent examples to base the remaining work upon.

Please remember to check out our CONTRIBUTING.md guide to get started... and thank you in advance for your contributions!

Hi guys!

I would like to work on the last issue: actions_workflow_runs.go

Thank you, @ayzu! It is yours.

Testing out the CreateOrUpdateSecret function, I seem to always be getting a 204 No Content response back even when creating new secrets (which should return 201 Created). I'm curious if anyone else has seen this or if perhaps I'm getting a cached response from my own code?

@martinssipenko - can you please comment on https://github.com/google/go-github/issues/1399#issuecomment-592118436 ?

@gmlewis @bramwelt I tested the API manually and despite what documentations suggests, it indeed returns 204 No Content on both create and update.

I've reached out to GitHub support and updated the conversion with them in #1402, https://github.com/google/go-github/pull/1402#issuecomment-592332173

I'll post their response there and will mention you so you both are up to date.

Thank you, @martinssipenko ! Your efforts are greatly appreciated!

Agreed, thank you lots @martinssipenko !! Truly appreciate it :slightly_smiling_face:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gmlewis picture gmlewis  路  3Comments

gmlewis picture gmlewis  路  3Comments

gmlewis picture gmlewis  路  3Comments

dmitshur picture dmitshur  路  3Comments

mungojam picture mungojam  路  3Comments