Go-github: Support preview Organizations Membership API and new filter

Created on 19 Jan 2017  路  7Comments  路  Source: google/go-github

Most helpful comment

Hey @gmlewis

I would like to share my research on the implementation of the new endpoints mentioned in the announcement:

Endpoint | Implemented | File:Method
---------|----|-----
Review a user's permission level | Yes | repos_collaborators.go:GetPermissionLevel
List outside collaborators | Yes | orgs_outside_collaborators.go:ListOutsideCollaborators
Remove an outside collaborator | No | -
Convert a member to an outside collaborator | No | -
List pending organization invitations| Yes |orgs_members.go:ListPendingOrgInvitations
List pending team invitations| Yes |orgs_teams.go:ListPendingTeamInvitations

If no one else is working on this, I would be more than happy to implement the missing endpoints.

All 7 comments

Hi, I'd like to work on it.

The issue sounds like there already is some code that lists organization's outside collaborator, and only the support for the new filter is to be added, but I couldn't find any. Am I missing something, or should I also write the code for that?

Thank you, @glapul - I'll send you an invite so that I can assign it to you.

You are correct. The new Organizations Membership API needs to be supported too.

Announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/
I'll change the label for this issue, and it can address both.

538 I've implemented the support for listing outside collaborators. Feedback?

Should this be closed, as #538 was closed and merged?

From a quick glance at this announcement: https://developer.github.com/changes/2016-11-28-preview-org-membership/ it appears that #538 did not fully support all the new API endpoints. For example, I don't think Remove an outside collaborator was addressed. There may be more, and part of the ownership of an issue (in my opinion) is to investigate what all is needed to completely resolve the issue.

If @glapul would like to complete this issue, then @glapul is welcome to... otherwise if someone else would like to read the announcements and add the missing endpoints, that is fine with me too.

Hey @gmlewis

I would like to share my research on the implementation of the new endpoints mentioned in the announcement:

Endpoint | Implemented | File:Method
---------|----|-----
Review a user's permission level | Yes | repos_collaborators.go:GetPermissionLevel
List outside collaborators | Yes | orgs_outside_collaborators.go:ListOutsideCollaborators
Remove an outside collaborator | No | -
Convert a member to an outside collaborator | No | -
List pending organization invitations| Yes |orgs_members.go:ListPendingOrgInvitations
List pending team invitations| Yes |orgs_teams.go:ListPendingTeamInvitations

If no one else is working on this, I would be more than happy to implement the missing endpoints.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

adrienzieba picture adrienzieba  路  3Comments

mungojam picture mungojam  路  3Comments

propertone picture propertone  路  3Comments

zulhfreelancer picture zulhfreelancer  路  3Comments

gmlewis picture gmlewis  路  3Comments