Gnome-shell-extension-gsconnect: Contacts with non-numeric address/phone confuse Messaging app

[sredman]

Describe the bug
I have a conversation in the SMS interface which properly shows the correct preview text (in the left panel), but clicking the contact pulls up the wrong conversation

To Reproduce
Steps to reproduce the behavior:

1. Open SMS interface
2. Click on this particular contact (others that I have clicked seem okay)
3. Wrong conversation is opened

Expected behavior
The conversation history for this contact should be opened

Screenshots
Here is a screen shot of the SMS GUI - Notice that the preview text under the selected contact does not match the actually-shown message:

Here is the screenshot of the same conversation from the phone:

Debug output
I have debug output but I do not see anything relevant-looking

System Details (please complete the following information):

• GSConnect version: 16 (git commit tag cdc4015b7af613327f0add7bef80fb748b162ba3)
  
  
  
  • Installed from: Github
  
  
• GNOME/Shell version: Plasma (gjs 1.52.3)
• Distro/Release: Fedora 28

GSConnect environment (if applicable):

• Paired Device(s): OnePlus 6T
• KDE Connect app version: 1.10 (master build)
• Plugin(s): SMS

[sredman]

Upstream, our app matches this contact correctly. A possible suggestion is that this is due to the canonicalization of the incoming email address. Here is how we do that: https://cgit.kde.org/kdeconnect-kde.git/tree/smsapp/conversationlistmodel.cpp#n200

[zabi94]

I have the same problem, all conversations seem to be affected, in my case. The content shown is the one from the least recent conversation (at the bottom of the list)

Ubuntu 18.04 - GSConnect 16 installed from Github
OnePlus6 - KDE Connect app v1.10

[andyholmes]

Do you also have conversations with contacts whose address/phone number is non-numeric (eg. an e-mail address)?

[zabi94]

Yes, most of my sms conversation are 2fa code providers or companies, their "number" is often a simple name (Like Iliad)

[andyholmes]

Okay, thanks. I'll try and have this fixed for the next release.

[andyholmes]

Here's an updated Zip including the fix from bef2fec:

[email protected] (removed, see below)

[andyholmes]

Sorry, sorry. Properly fixed in cc219a4:

[email protected]

cc @shoetten

[shoetten]

Thank you for a great app! The UI works perfectly now. My friends are happy, that i'm finally replying to sms again ;)