Gnome-shell-extension-gsconnect: Device icon not scaled to display density

[flipflop97]

I noticed the device icon with the battery circle on the left of each device should be twice the size as it is for me, this is caused by my display using 200% scaling. Setting scaling to 100% makes it behave like normal and setting it to 300% makes it even smaller relatively.

Big device icon (from readme)

Small device icon (200% scaling)

[danieldeng2]

Noticed as well. Anyone have any idea how to fix?

[danieldeng2]

This might be helpful: https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/71

[andyholmes]

For most Clutter elements this should be done automatically, but the device icon is a custom cairo surface so I'll have to make some changes to support HiDPI screens. I'm approaching the time to merge the wip-rewrite branch so this won't be done until after that.

[andyholmes]

I thought I'd just update you to let you know I'm working hard to get the rewrite in shape to merge. I'd just like to get everything major settled (like new/deprecated settings, file paths) so I can do a "feature freeze" and a release candidate (v13-RC1) soon after.

Since I don't have a HiDPI screen and emulating one is difficult, I'd appreciate help testing the extension from people that do, to make sure everything looks like it is supposed to. I was told by a Gnome dev that this is usually handled automatically at render time, but maybe there are some other exceptions where it has to be adjusted manually (like that Remote Input bug) that I can't predict.

On the upside, I might be able to use the opportunity to make the whole widget resizable in CSS, which would let themers include adjustments for their "compact" variants.

[flipflop97]

Thanks for the update! Once you've merged the rewrite branch, I'll gladly help testing it by finding HiDPI related bugs and submitting PRs where I can. I've already partially (hardcoded for 200%) fixed this issue for me so I can probably help making this widget resizable.

[andyholmes]

Hi, I've recently merged the rewrite and I'd like to address the HiDPI issues in GSConnect before doing a release candidate. If you have the time I'd appreciate help tracking those down and fixing them since I don't have a HiDPI screen myself.

I pushed a change that checks the scale factor before loading the device icon, and the overall size is set in CSS. I'm hoping this at least partially fixes the problem.

[danieldeng2]

Hi @andyholmes I just installed the master branch and the same problem still persists.

[andyholmes]

Okay, I think I fixed it this time.

[danieldeng2]

Comfirmed, thanks for the hard work.