Givewp: Not able to tell differences between payment gateways due to same labels

[DevinWalker]

@raftaar1191 commented on Thu Nov 23 2017

Issue Overview

See the video: http://screencast-o-matic.com/watch/cbX0Yv2uex

Expected Behavior

Must notify the user through which gateway there are going to make the payment

Current Behavior

Can't make a diff unless making a payment

Possible Solution

Adding some title at the back of the gateway like Credit Card ( 2checkout )

Steps to Reproduce (for bugs)

See the Video

Todos

• [x] Tests
• [x] Documentation

WordPress Environment

### WordPress Environment ###

Home URL: http://localgive.dev
Site URL: http://localgive.dev
WP Version: 4.9
WP Multisite: –
WP Memory Limit: 256 MB
WP Debug Mode: ✔
WP Cron: ✔
Language: en_US
Permalink Structure: /%postname%/
Show on Front: posts
Table Prefix Length: 3
Table Prefix Status: Acceptable
Admin AJAX: Inaccessible
Registered Post Statuses: publish, future, draft, pending, private, trash, auto-draft, inherit, refunded, failed, revoked, cancelled, abandoned, processing, preapproval

### Server Environment ###

Hosting Provider: DBH: localhost, SRV: localgive.dev
TLS Connection: Connection uses TLS 1.2
TLS Connection: Probably Okay
Server Info: nginx/1.10.1
PHP Version: 7.1.4
PHP Post Max Size: 1,000 MB
PHP Time Limit: 900
PHP Max Input Vars: 3000
PHP Max Upload Size: 1,000 MB
cURL Version: ❌ 7.38.0, OpenSSL/1.0.1t - We recommend a minimum cURL version of 7.40.
SUHOSIN Installed: –
MySQL Version: ❌ 5.5.55 - We recommend a minimum MySQL version of 5.6. See: WordPress Requirements
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
gzip: ✔
GD Graphics Library: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

### Give Configuration ###

Give Version: 1.8.17
Upgraded From: 1.8.17
Test Mode: Enabled
Currency Code: INR
Currency Position: Before
Decimal Separator: .
Thousands Separator: ,
Success Page: http://localgive.dev/donation-confirmation/
Failure Page: http://localgive.dev/donation-failed/
Donation History Page: http://localgive.dev/donation-history/
Give Forms Slug: /donations/
Enabled Payment Gateways: Test Donation, Offline Donation, PayPal Standard, Stripe - Credit Card, Stripe - ACH, 2Checkout
Default Payment Gateway: Test Donation
PayPal IPN Verification: Enabled
PayPal IPN Notifications: N/A
Admin Email Notifications: Enabled
Donor Email Access: Enabled

### Session Configuration ###

Give Use Sessions: Enabled
Session: Disabled

### Active Give Add-ons ###

Give - 2Checkout Gateway: ❌ Unlicensed – by WordImpress – 1.0.2
Give - Stripe Gateway: ❌ Unlicensed – by WordImpress – 1.5

### Other Active Plugins ###

Give Cutom Plugin: by  –
Query Monitor: by John Blackbourn – 2.17.0

### Inactive Plugins ###

Debug Bar Console: by koopersmith – 0.3
Debug Bar Cron: by Zack Tollman, Helen Hou-Sandi – 0.1.2
Debug Bar Extender: by Thorsten Ott, Automattic – 0.5
Developer: by Automattic – 1.2.6
Duplicate Post: by Enrico Battocchi – 3.2
Give - AmeriCloud Payments: by AmeriCloud Solutions, Inc. – 1.2.0
Give - Authorize.net Gateway: by WordImpress – 1.3
Give - CCAvenue Gateway: by WordImpress – 1.0
Give - Currency Switcher: by WordImpress – 1.0.0
Give - Email Reports: by WordImpress – 1.0.1
Give - Fee Recovery: by WordImpress – 1.3
Give - Form Countdown: by WordImpress – 1.0
Give - Form Field Manager: by WordImpress – 1.2.4
Give - Gift Aid: by WordImpress – 1.0.0
Give - Manual Donations: by WordImpress – 1.2
Give - PayPal Pro Gateway: by WordImpress – 1.1.4
Give - PDF Receipts: by WordImpress – 2.1
Give - Per Form Emails: by WordImpress – 1.0.2
Give - Razorpay: by WordImpress – 1.1.0
Give - Recurring Donations: by WordImpress – 1.4.1
Give - Tributes: by WordImpress – 1.2
Give - WePay Gateway: by WordImpress – 1.3.1
Give - WP All Import Addon: by Ben Meredith – 1.0
Give - Zapier: by WordImpress – 1.1.2
Give to ZBS CRM Connector: by https://zerobscrm.com – 1.0.1
Hookr: by @explodybits – 1.0.0 (beta)
Loco Translate: by Tim Whitlock – 2.0.16
Log Deprecated Notices: by Andrew Nacin – 0.4
Log Viewer: by Markus Fischbacher – 14.05.04
Redis Object Cache: by Till Krüss – 1.3.5
Rewrite Rules Inspector: by Daniel Bachhuber, Automattic – 1.2.1
rtMedia for WordPress, BuddyPress and bbPress: by rtCamp – 4.4.4
UpdraftPlus - Backup/Restore: by UpdraftPlus.Com, DavidAnderson – 1.13.12
User Switching: by John Blackbourn – 1.3.0
WooCommerce: by Automattic – 3.2.3
WordPress Importer: by wordpressdotorg – 0.6.3
WP Downgrade | Specific Core Version: by Reisetiger – 1.1.4
WP Rollback: by WordImpress – 1.5
WP Super Cache - Clear all cache: by Apasionados.es – 1.4
Yoast SEO: by Team Yoast – 5.8

### Active MU Plugins ###

Local by Flywheel Relative URL (for Live Links): by Flywheel – 1.0

### Theme ###

Name: Twenty Sixteen
Version: 1.3
Author URL: https://wordpress.org/
Child Theme: No – If you're modifying Give on a parent theme you didn't build personally, then we recommend using a child theme. See: How to Create a Child Theme

---

@DevinWalker commented on Tue Nov 28 2017

This is more of a Give core issue rather than specific to this gateway. I'm moving this to core.

[DevinWalker]

New Gateway Selection Interface

Here's what I propose to we do to fix this issue should someone use two "Credit Card" payment gateways. The solution is essentially create a "Label" field that adjusts the gateway's label output per gateway.

Concept:

[ravinderk]

@DevinWalker This is a good idea.

[raftaar1191]

Nice Idea @DevinWalker It look really awesome

[ravinderk]

@Sidsector9 Reopen this issue because we are using the grid which needs browser compatibility.

[raftaar1191]

@Sidsector9 @ravinderk Getting JS error when admin click on any of the checkbox to enable or disable it /

[DevinWalker]

@ravinderk closing this due to PR above.