Givewp: Change some settings to properly reflect Enable/Disable Correctly

[mathetos]

Throughout the plugin we often mixed the purposes of settings between Enable/Disable, or Show/Hide in ways that can cause confusion.

Here's one example:

Three different settings, checking one enables, while checking another disables.

I propose something like the following instead:

This would apply to every setting that uses language like True/False or On/Off, Show/Hide, Enable/Disable. Consistency in our settings is important to the user experience.

[DevinWalker]

What's the UI best practice here? I feel a checkbox is pretty easy to understand... but radios, makes sense too.

[mathetos]

I think if it's a checkbox it needs to ALWAYS be "Enable". To check it in order to "Disable" is counterintuitive. But I think the radio buttons make it all as obvious as possible and avoid any confusion because they show ALL the options directly.

[ramiy]

I agree with @mathetos.

Although check-boxes are simple operators, the current wording "Enable this option if you would like to disable the ..." can be very confusing. With radio button we remove the confusion factor from the equation.

[mathetos]

OK, here's a list of all the options on the "Donations > Settings" page tabs that need updating:

Payment Gateways Tab

• [x] Test Mode -- Enabled (default) | Disabled
• [x] "PayPal IPN Verification" -- Enabled (default) | Disabled (Enabled is default)
• [x] "Collect Billing Details" (Offline Donations) -- Yes | No (default)

Display Options Tab

• [x] "Disable CSS" change label to "Native Give Styles" -- Enable (default) | Disable
• [x] "Enable Floating Labels" change to "Floating Labels" -- Enable | Disable (default)
• [x] "Disable Welcome Screen" change to "Welcome Screen" -- Enable (default) | Disable
• [x] "Disable Form Single Views" change to "Form Single Views" -- Enable (default) | Disable
• [x] "Disable Form Archives" change to "Form Archives" -- Enable (default) | Disable
• [x] "Disable Form Excerpts" change to "Form Excerpts" -- Enable (default) | Disable
• [x] "Disable Form Featured Image" change to "Form Featured Image" -- Enable (default) | Disable
• [x] "Disable Single Form Sidebar" change to "Single Form Sidebar" -- Enable (default) | Disable
• [x] "Enable Form Categories" change to "Form Categories" -- Enable | Disable (default)
• [x] "Enable Form Tags" change to "Form Tags" -- Enable | Disable (default)

Emails Tab

• [x] "Disable Admin Notifications" change to "Admin Notifications" -- Enable (default) | Disable

Advanced Tab

• [x] "Email Access" -- Enable | Disable (default)
• [x] "Remove All Data on Uninstall" -- Yes | No (default)
• [x] "Disable the_content filter" change to "Single Form Content Filter" -- Enable (default) | Disable
• [x] "Load Scripts in Footer?" -- Yes | No (default)

Add-ons

I'll make additional issues in the respective Addons that reference this issue, but from a quick review this would apply most often to the Payment Gateways.

[DevinWalker]

This is complete in release/1.8