Giveth-dapp: Bug when trying to disburse milestone

[Kisgus]

We get the same error message in the Venezuela Campaign as in https://github.com/Giveth/giveth-dapp/issues/445 when trying to "disburse" funds

Milestone 1

https://beta.giveth.io/campaigns/5c0e84ea06392d786b64d484/milestones/5c0e959806392d786b64d48c

Milestone 2

https://beta.giveth.io/campaigns/5c0e84ea06392d786b64d484/milestones/5c0e959806392d786b64d48c

[Kisgus]

Thanks for looking into this @perissology, do you have any fix in mind?

[ewingrj]

yes, it's fixed but hasn't been released yet. There were some big code changes that this fix got made on top of. So we're still testing. Hopefully within the next few days.

Unfortunately there is a max of 8 donations that can be withdrawn at a time, so you will have to "withdraw" multiple times to get all the funds.

I'm not sure if you're a dev or not. You can always run this repo locally, and set the .env.local file environment=beta and it will run the latest codebase against the beta data.

[Kisgus]

Okay thanks. Not really a dev, so I will just be waiting. Is it correctly understood once this release has been merged I will be able to disburse all at once? Alternatively if I had the option in the UI to just disburse 8 tx at the time that could also do the trick on the short term, then I could manually just disburse it a few times.

[ewingrj]

you will only be able to disburse 8 at a time. It is a current limitation w/ the smart contracts

[Kisgus]

So if that option of "disburse 8" would be in the UI that would be totally okay without contract updates.
Right now I only have the option of "disbursing" in the UI, which tries to disburse all and therefore fails.

[ewingrj]

yep, it will only disburse max 8 & show a note that you will need to disburse again

[vojtechsimetka]

After the latest UI release the disburse button is no longer there even though there are still some donations to be disbursed. Reported by @Kisgus

[mroberts10]

Hi @Kisgus can we close this issue now?

[Kisgus]

We are now trying to disburse, seems to work, will confirm when/if funds has been successfully disbursed :)

[GriffGreen]

This is still an issue it seems
https://beta.giveth.io/campaigns/5cfe3366228b71296a491fa7/milestones/5d1ba874bd45530e23ad86ed
In this milestone there is a bunch of small donations

We need a more robust way to deal with lots of small donations in one go... I think a pop up similar to the warning that there will be 2 donations

[arbreton]

Reading through this issue now

[GriffGreen]

@aminlatifi this is related to #871

[GriffGreen]

this still doesnt work.... we need to do some sort of individual hack for https://beta.giveth.io/campaigns/5cfe3366228b71296a491fa7/milestones/5d1ba874bd45530e23ad86ed

[arbreton]

I applied a fix that should allow collecting at 5 per transaction, it should work now! please keep me posted @GriffGreen

[arbreton]

Due to Rinkeby data unsync, prioritizing Rinkeby faucet stability for prevention and focusing on Dapp 2.0 for complete refactor on data sync