Giveth-dapp: Ctrl-F 螢 and Delete it! Put ETH after each number instead

Created on 1 Apr 2018  路  3Comments  路  Source: Giveth/giveth-dapp

螢 is weird... i don't see anyone really use it, I would just use ETH but I am open to hear other thoughts on that.

question help wanted
Source
picture GriffGreen
👍2

Most helpful comment

An update to Blockfolio actually added this feature in the past few days. To show balance in ETH and it is using this symbol. However it might make sense to show ETH. Lots of sites show USD instead of $

picture Alonski on 1 Apr 2018
👍2

All 3 comments

An update to Blockfolio actually added this feature in the past few days. To show balance in ETH and it is using this symbol. However it might make sense to show ETH. Lots of sites show USD instead of $

Alonski picture Alonski on 1 Apr 2018
👍2

Ok maybe I should scroll down more before starting to fix issues. I saw that @deamme referenced this issue already in a PR.

  • changed all instances of 螢 to ETH and rearranging the order (first number then ETH)

If you go for @deamme 's commit, don't hesitate to delete the branch

geleeroyale picture geleeroyale on 9 Apr 2018

Fixed in #281

vojtechsimetka picture vojtechsimetka on 10 Apr 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

krrisis picture krrisis  路  6Comments
MoeNick picture MoeNick  路  5Comments
MoeNick picture MoeNick  路  6Comments
danelsuga picture danelsuga  路  6Comments
Alonski picture Alonski  路  4Comments